-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add with-context-api example #5154
Conversation
"start": "next start" | ||
}, | ||
"dependencies": { | ||
"next": "latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use canary here, as it doesn't work on 6.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should be "next": "7.0.0-canary.16"
?
Sorry, my first PR 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"next": "^7.0.0-canary.16",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be good with yarn add next@canary
👍
@@ -0,0 +1,19 @@ | |||
import App, { Container } from 'next/app' | |||
/* First we import our provider */ | |||
import NoteProvider from '../components/CounterProvider' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wesbos example used NoteProvider
But this here should be called CounterProvider
now, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YEs - sorry I ripped this out of another app :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. it should be CounterProvider. I based on @wesbos example and forget to change that import
resolves #4182