Fix turbo usage in tests #44715
Fix turbo usage in tests #44715
Conversation
jankaifer
requested review from
timneutkens,
ijjk,
shuding,
a team,
styfle,
huozhi,
padmaia and
balazsorban44
as code owners
ijjk
added
create-next-app
|
The stats action is failing because So we can either merge this in 2 phases or just ignore that one failing Action. |
|
It's weird I ran those CI actions locally (that docker command on top) and it passes 🤷. |
|
Hmm, it passes now. |
| @@ -8,6 +8,9 @@ | |||
| "url": "vercel/next.js", | |||
| "directory": "packages/eslint-config-next" | |||
| }, | |||
| "scripts": { | |||
| "test-pack": "cd ../../ && pnpm test-pack eslint-config-next" | |||
There was a problem hiding this comment.
This seems redundant that the package has to pass the name. Can we update the script to derive the current package by reading process.cwd() ?
There was a problem hiding this comment.
Hmm, I dig into it. And I would need to repeat that ts-node magical initialization.
Not worth it. But good point.
I want to merge this one. And we probably want to merge |
jankaifer
deleted the
jankaifer/next-344-try-rethinking-turbo-usage-in-tests-and
branch
ts-node.mtsfor scriptsI made the script
pnpm packcompatible for easier switching in the future.Right now pnpm pack can't be used because it doesn't include swc binaries in the resulting tarball. Will solve it in a separate PR.
Testing
I tried testing this by editing the next core, but could someone double check please?
Questions
I made
test-packturbo task depend only on source files (that are not gitignored). Which is not great, it would be better if I could mark it as dependent onbuildbut that could be a bit slower since people usedev.Also If the dev produces something janky,
test-packmight cache it.I'm not sure how common that is.