Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't throw 500 error when Content-type is invalid #24818

Merged
merged 4 commits into from
May 5, 2021
Merged

Don't throw 500 error when Content-type is invalid #24818

merged 4 commits into from
May 5, 2021

Conversation

vitalybaev
Copy link
Contributor

Fixes #24768

Bug

  • Related issues linked using fixes #number
  • Integration tests added

@ijjk ijjk added the type: next label May 5, 2021
timneutkens
timneutkens approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ijjk
Copy link
Member

ijjk commented May 5, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
buildDuration 14.9s 15s ⚠️ +125ms
buildDurationCached 4.8s 4.6s -213ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +234 B
Page Load Tests Overall increase ✓
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.517 2.466 -0.05
/ avg req/sec 993.23 1013.64 +20.41
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.404 1.314 -0.09
/error-in-render avg req/sec 1780.47 1902.53 +122.06
Client Bundles (main, webpack, commons)
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.3 kB 19.3 kB ✓
webpack-HASH.js gzip 996 B 996 B ✓
Overall change 59.6 kB 59.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.04 kB 3.04 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 8.51 kB 8.51 kB ✓
Client Build Manifests
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
_buildManifest.js gzip 393 B 393 B ✓
Overall change 393 B 393 B ✓
Rendered Page Sizes
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
index.html gzip 561 B 561 B ✓
link.html gzip 570 B 570 B ✓
withRouter.html gzip 557 B 557 B ✓
Overall change 1.69 kB 1.69 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
buildDuration 18.3s 18.4s ⚠️ +141ms
buildDurationCached 7s 6.9s -71ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +234 B
Client Bundles (main, webpack, commons)
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.3 kB 19.3 kB ✓
webpack-HASH.js gzip 996 B 996 B ✓
Overall change 59.6 kB 59.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.04 kB 3.04 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 8.51 kB 8.51 kB ✓
Client Build Manifests
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
_buildManifest.js gzip 393 B 393 B ✓
Overall change 393 B 393 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
_error.js 1.34 MB 1.34 MB ⚠️ +81 B
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 1.34 MB 1.35 MB ⚠️ +81 B
link.js 1.4 MB 1.4 MB ⚠️ +83 B
routerDirect.js 1.39 MB 1.39 MB ⚠️ +79 B
withRouter.js 1.39 MB 1.39 MB ⚠️ +81 B
Overall change 6.9 MB 6.9 MB ⚠️ +405 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
buildDuration 12.4s 13.2s ⚠️ +835ms
buildDurationCached 5.4s 5.2s -229ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +234 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.508 2.529 ⚠️ +0.02
/ avg req/sec 996.89 988.56 ⚠️ -8.33
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.342 1.399 ⚠️ +0.06
/error-in-render avg req/sec 1862.73 1787.38 ⚠️ -75.35
Client Bundles (main, webpack, commons)
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary vitalybaev/next.js 24768-500-on-api-request-when-content-type Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 4232538

@kodiakhq kodiakhq bot merged commit 54ff322 into vercel:canary May 5, 2021
@vitalybaev vitalybaev deleted the 24768-500-on-api-request-when-content-type branch May 5, 2021 14:41
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@vitalybaev
Don't throw 500 error when Content-type is invalid (vercel#24818)
6122db1 
Fixes vercel#24768

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

500 error when content-type header is not formatted correctly
3 participants
@vitalybaev @ijjk @timneutkens