Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding globalStyled with styled components #16783

Merged
merged 6 commits into from
Sep 10, 2020
Merged

Adding globalStyled with styled components #16783

merged 6 commits into from
Sep 10, 2020

Conversation

ArthurMaverick
Copy link
Contributor

@ArthurMaverick ArthurMaverick commented Sep 2, 2020 •
edited
Loading

Changes

  • adding global styles with styled components in _app.js

Details

  • Returns a StyledComponent that does not accept children. Place it at the top of your React tree and the global styles will be injected when the component is "rendered".
  • Since the GlobalStyle component is a StyledComponent, that means it also has access to theming from the component if provided.

@ArthurMaverick
Adding globalStyled with styled components
bdc3526 
# Changes

- adding global styles with styled components in _app.js

- Details

- Returns a StyledComponent that does not accept children. Place it at the top of your React tree and the global styles will be injected when the component is "rendered".
- Since the GlobalStyle component is a StyledComponent, that means it also has access to theming from the <ThemeProvider> component if provided.
@ijjk ijjk added the examples Issue/PR related to examples label Sep 2, 2020
@ijjk
Copy link
Member

ijjk commented Sep 2, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
buildDuration 12.2s 12s -193ms
nodeModulesSize 55.9 MB 55.9 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.217 2.13 -0.09
/ avg req/sec 1127.43 1173.45 +46.02
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.195 1.166 -0.03
/error-in-render avg req/sec 2092.87 2143.88 +51.01
Client Bundles (main, webpack, commons)
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e1c4209..e2c9.js gzip 7.32 kB 7.32 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9077898..dule.js gzip 6.38 kB 6.38 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.2 kB 52.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-ae98065..267e.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
index.html gzip 971 B 971 B ✓
link.html gzip 976 B 976 B ✓
withRouter.html gzip 963 B 963 B ✓
Overall change 2.91 kB 2.91 kB ✓
Serverless Mode
General
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
buildDuration 13.3s 13.6s ⚠️ +284ms
nodeModulesSize 55.9 MB 55.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e1c4209..e2c9.js gzip 7.32 kB 7.32 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9077898..dule.js gzip 6.38 kB 6.38 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.2 kB 52.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-ae98065..267e.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: bdc3526

@ijjk
Copy link
Member

ijjk commented Sep 2, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
buildDuration 13s 13.1s ⚠️ +16ms
nodeModulesSize 55.9 MB 55.9 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.365 2.327 -0.04
/ avg req/sec 1057.11 1074.46 +17.35
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.254 1.313 ⚠️ +0.06
/error-in-render avg req/sec 1994.26 1904.01 ⚠️ -90.25
Client Bundles (main, webpack, commons)
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e1c4209..e2c9.js gzip 7.32 kB 7.32 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9077898..dule.js gzip 6.38 kB 6.38 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.2 kB 52.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-ae98065..267e.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
index.html gzip 971 B 971 B ✓
link.html gzip 976 B 976 B ✓
withRouter.html gzip 963 B 963 B ✓
Overall change 2.91 kB 2.91 kB ✓
Serverless Mode
General
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
buildDuration 14.8s 14.8s ⚠️ +64ms
nodeModulesSize 55.9 MB 55.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e1c4209..e2c9.js gzip 7.32 kB 7.32 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9077898..dule.js gzip 6.38 kB 6.38 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.2 kB 52.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-ae98065..267e.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: 3ff448d

Timer
Timer previously approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ijjk
Copy link
Member

ijjk commented Sep 10, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
buildDuration 11.3s 11.2s -56ms
nodeModulesSize 57 MB 57 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.974 2.221 ⚠️ +0.25
/ avg req/sec 1266.15 1125.41 ⚠️ -140.74
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.235 1.213 -0.02
/error-in-render avg req/sec 2024.61 2061.79 +37.18
Client Bundles (main, webpack, commons)
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
677f882d2ed8..4c1a.js gzip 10.8 kB 10.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-18c9b45..05ea.js gzip 7 kB 7 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.5 kB 57.5 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.67 kB 6.67 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-3e4ebe7..dule.js gzip 6.07 kB 6.07 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 993 B 993 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode
General
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
buildDuration 12.4s 12.4s ⚠️ +62ms
nodeModulesSize 57 MB 57 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
677f882d2ed8..4c1a.js gzip 10.8 kB 10.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-18c9b45..05ea.js gzip 7 kB 7 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.5 kB 57.5 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.67 kB 6.67 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-3e4ebe7..dule.js gzip 6.07 kB 6.07 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary ArthurMaverick/next.js patch-1 Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.04 MB 1.04 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.31 MB 5.31 MB ✓
Commit: f82bc58

@Timer Timer merged commit 91b4a2b into vercel:canary Sep 10, 2020
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
@ArthurMaverick @Timer
Adding globalStyled with styled components (vercel#16783)
42bb0b7 
Co-authored-by: Joe Haddad <[email protected]>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArthurMaverick @ijjk @Timer