chore: update example names to match their folders #16268

merceyz · 2020-08-17T18:46:16Z

What's the problem this PR addresses?

A decent amount of the examples don't have a name field in package.json that matches their folder name, meaning they either lack a name or the names are duplicated.

I was testing Yarn 2 workspaces using the entire examples directory and needed to get rid of the duplicates.

How did you fix it?

Updated the names to match the names of their folders

lfades

@merceyz Thank you! Everything looks good 💯

Did you use an script to check which examples didn't have a matching name?

examples/with-stencil/packages/web-app/package.json

merceyz · 2020-08-17T18:56:16Z

Did you use an script to check which examples didn't have a matching name?

Yes, wrote a quick script to loop over the examples folder and update the name in package.json to match the folder name

ijjk · 2020-08-17T18:59:08Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
buildDuration	13.2s	13.2s	⚠️ +3ms
nodeModulesSize	57.6 MB	57.6 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.587	2.503	-0.08
/ avg req/sec	966.51	998.96	+32.45
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.514	1.447	-0.07
/error-in-render avg req/sec	1651.59	1727.26	+75.67

Client Bundles (main, webpack, commons)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..b4e6.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-bec7641..f131.js gzip	6.72 kB	6.72 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..dule.js gzip	6.08 kB	6.08 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-b7036a3..dule.js gzip	5.79 kB	5.79 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-00b8972..6e4e.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.7 kB	7.7 kB	✓

Client Pages Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-72c64d9..dule.js gzip	1.27 kB	1.27 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
index.html gzip	948 B	948 B	✓
link.html gzip	953 B	953 B	✓
withRouter.html gzip	939 B	939 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
buildDuration	15s	14.7s	-283ms
nodeModulesSize	57.6 MB	57.6 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..b4e6.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-bec7641..f131.js gzip	6.72 kB	6.72 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..dule.js gzip	6.08 kB	6.08 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-b7036a3..dule.js gzip	5.79 kB	5.79 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-00b8972..6e4e.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.7 kB	7.7 kB	✓

Client Pages Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-72c64d9..dule.js gzip	1.27 kB	1.27 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.07 MB	1.07 MB	✓
routerDirect.js	1.06 MB	1.06 MB	✓
withRouter.js	1.06 MB	1.06 MB	✓
Overall change	5.27 MB	5.27 MB	✓

Commit: a80ca7d

ijjk · 2020-08-17T19:03:42Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
buildDuration	12.6s	13s	⚠️ +371ms
nodeModulesSize	57.6 MB	57.6 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.474	2.4	-0.07
/ avg req/sec	1010.63	1041.46	+30.83
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.509	1.494	-0.01
/error-in-render avg req/sec	1656.56	1673.78	+17.22

Client Bundles (main, webpack, commons)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..b4e6.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-bec7641..f131.js gzip	6.72 kB	6.72 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..dule.js gzip	6.08 kB	6.08 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-b7036a3..dule.js gzip	5.79 kB	5.79 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-00b8972..6e4e.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.7 kB	7.7 kB	✓

Client Pages Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-72c64d9..dule.js gzip	1.27 kB	1.27 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
index.html gzip	948 B	948 B	✓
link.html gzip	953 B	953 B	✓
withRouter.html gzip	939 B	939 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
buildDuration	14.7s	14.4s	-217ms
nodeModulesSize	57.6 MB	57.6 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..b4e6.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-bec7641..f131.js gzip	6.72 kB	6.72 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..dule.js gzip	6.08 kB	6.08 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-b7036a3..dule.js gzip	5.79 kB	5.79 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-00b8972..6e4e.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.7 kB	7.7 kB	✓

Client Pages Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-72c64d9..dule.js gzip	1.27 kB	1.27 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.07 MB	1.07 MB	✓
routerDirect.js	1.06 MB	1.06 MB	✓
withRouter.js	1.06 MB	1.06 MB	✓
Overall change	5.27 MB	5.27 MB	✓

Commit: 74d5c47

ijjk · 2020-08-17T19:19:01Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
buildDuration	13.9s	13.9s	-33ms
nodeModulesSize	57.6 MB	57.6 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.629	2.687	⚠️ +0.06
/ avg req/sec	950.88	930.52	⚠️ -20.36
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.59	1.549	-0.04
/error-in-render avg req/sec	1572.07	1614.45	+42.38

Client Bundles (main, webpack, commons)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..b4e6.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-bec7641..f131.js gzip	6.72 kB	6.72 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..dule.js gzip	6.08 kB	6.08 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-b7036a3..dule.js gzip	5.79 kB	5.79 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-00b8972..6e4e.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.7 kB	7.7 kB	✓

Client Pages Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-72c64d9..dule.js gzip	1.27 kB	1.27 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
index.html gzip	948 B	948 B	✓
link.html gzip	953 B	953 B	✓
withRouter.html gzip	939 B	939 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
buildDuration	16.2s	16.4s	⚠️ +245ms
nodeModulesSize	57.6 MB	57.6 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..b4e6.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-bec7641..f131.js gzip	6.72 kB	6.72 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..dule.js gzip	6.08 kB	6.08 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-b7036a3..dule.js gzip	5.79 kB	5.79 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-00b8972..6e4e.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.7 kB	7.7 kB	✓

Client Pages Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-72c64d9..dule.js gzip	1.27 kB	1.27 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.07 MB	1.07 MB	✓
routerDirect.js	1.06 MB	1.06 MB	✓
withRouter.js	1.06 MB	1.06 MB	✓
Overall change	5.27 MB	5.27 MB	✓

Commit: 2c34f37

ijjk · 2020-08-22T01:20:42Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
buildDuration	10.3s	10.6s	⚠️ +344ms
nodeModulesSize	57.5 MB	57.5 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.894	1.823	-0.07
/ avg req/sec	1320.26	1371.4	+51.14
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.018	0.991	-0.03
/error-in-render avg req/sec	2456.6	2521.89	+65.29

Client Bundles (main, webpack, commons)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..4e55.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3aeb17d..193e.js gzip	7.2 kB	7.2 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e67bd4d..dule.js gzip	6.21 kB	6.21 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52 kB	52 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-28298..e0c9.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-65c8a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
index.html gzip	946 B	946 B	✓
link.html gzip	952 B	952 B	✓
withRouter.html gzip	937 B	937 B	✓
Overall change	2.83 kB	2.83 kB	✓

Serverless Mode

General

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
buildDuration	11.9s	11.9s	-61ms
nodeModulesSize	57.5 MB	57.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..4e55.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3aeb17d..193e.js gzip	7.2 kB	7.2 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e67bd4d..dule.js gzip	6.21 kB	6.21 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52 kB	52 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-28298..e0c9.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-65c8a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.07 MB	1.07 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.28 MB	5.28 MB	✓

Commit: 3d093ca

examples/with-stomp/package.json

lfades · 2020-09-02T00:02:22Z

@merceyz Hi there, can you resolve the conflicts 🙏 . Also it looks like there are order changes in the dependencies of some examples, but those don't seem to be expected or required to merge the PR.

ijjk · 2020-09-04T16:28:13Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
buildDuration	12.8s	13.4s	⚠️ +600ms
nodeModulesSize	56.7 MB	56.7 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.5	2.551	⚠️ +0.05
/ avg req/sec	1000.07	980.18	⚠️ -19.89
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.497	1.575	⚠️ +0.08
/error-in-render avg req/sec	1670.02	1587.13	⚠️ -82.89

Client Bundles (main, webpack, commons)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..b5de.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-195c642..b6b7.js gzip	7.08 kB	7.08 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.3 kB	57.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..dule.js gzip	6.4 kB	6.4 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-ad445e5..dule.js gzip	6.14 kB	6.14 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.3 kB	52.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
index.html gzip	968 B	968 B	✓
link.html gzip	975 B	975 B	✓
withRouter.html gzip	962 B	962 B	✓
Overall change	2.9 kB	2.9 kB	✓

Serverless Mode

General

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
buildDuration	14.6s	15.4s	⚠️ +785ms
nodeModulesSize	56.7 MB	56.7 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..b5de.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-195c642..b6b7.js gzip	7.08 kB	7.08 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.3 kB	57.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..dule.js gzip	6.4 kB	6.4 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-ad445e5..dule.js gzip	6.14 kB	6.14 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.3 kB	52.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.22 kB	4.22 kB	✓
hooks.html	3.86 kB	3.86 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.08 MB	1.08 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.29 MB	5.29 MB	✓

Commit: 859668d

ijjk · 2020-09-04T16:31:00Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
buildDuration	13.1s	13.1s	⚠️ +61ms
nodeModulesSize	56.7 MB	56.7 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.482	2.439	-0.04
/ avg req/sec	1007.43	1025.09	+17.66
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.464	1.558	⚠️ +0.09
/error-in-render avg req/sec	1707.52	1604.79	⚠️ -102.73

Client Bundles (main, webpack, commons)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..b5de.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-195c642..b6b7.js gzip	7.08 kB	7.08 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.3 kB	57.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..dule.js gzip	6.4 kB	6.4 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-ad445e5..dule.js gzip	6.14 kB	6.14 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.3 kB	52.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
index.html gzip	968 B	968 B	✓
link.html gzip	975 B	975 B	✓
withRouter.html gzip	962 B	962 B	✓
Overall change	2.9 kB	2.9 kB	✓

Serverless Mode

General

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
buildDuration	14.6s	14.4s	-188ms
nodeModulesSize	56.7 MB	56.7 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..b5de.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-195c642..b6b7.js gzip	7.08 kB	7.08 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.3 kB	57.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..dule.js gzip	6.4 kB	6.4 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-ad445e5..dule.js gzip	6.14 kB	6.14 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.3 kB	52.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.22 kB	4.22 kB	✓
hooks.html	3.86 kB	3.86 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.08 MB	1.08 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.29 MB	5.29 MB	✓

Commit: 555a7a9

merceyz · 2020-09-04T16:33:58Z

Hi there, can you resolve the conflicts pray .

Done

Also it looks like there are order changes in the dependencies of some examples, but those don't seem to be expected or required to merge the PR.

While not required it's the order they would have been placed in when installed so it reduces the diff for users, and Yarn v2 does this sort automatically when installing a project and since I run tests on the examples directory every now and then I'd like to not get this diff every time, but if you really don't want it I can revert it.

ijjk · 2020-09-04T16:39:29Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
buildDuration	13.3s	13.5s	⚠️ +282ms
nodeModulesSize	56.7 MB	56.7 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.439	2.42	-0.02
/ avg req/sec	1025.14	1032.97	+7.83
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.449	1.552	⚠️ +0.1
/error-in-render avg req/sec	1725.21	1611	⚠️ -114.21

Client Bundles (main, webpack, commons)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..b5de.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-195c642..b6b7.js gzip	7.08 kB	7.08 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.3 kB	57.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..dule.js gzip	6.4 kB	6.4 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-ad445e5..dule.js gzip	6.14 kB	6.14 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.3 kB	52.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
index.html gzip	968 B	968 B	✓
link.html gzip	975 B	975 B	✓
withRouter.html gzip	962 B	962 B	✓
Overall change	2.9 kB	2.9 kB	✓

Serverless Mode

General

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
buildDuration	14.8s	14.9s	⚠️ +10ms
nodeModulesSize	56.7 MB	56.7 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..b5de.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-195c642..b6b7.js gzip	7.08 kB	7.08 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.3 kB	57.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..dule.js gzip	6.4 kB	6.4 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-ad445e5..dule.js gzip	6.14 kB	6.14 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.3 kB	52.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.22 kB	4.22 kB	✓
hooks.html	3.86 kB	3.86 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.08 MB	1.08 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.29 MB	5.29 MB	✓

Commit: 995f721

lfades

@merceyz Good work. Thank you!

ijjk · 2020-09-05T21:05:10Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
buildDuration	13.1s	13.2s	⚠️ +84ms
nodeModulesSize	56.7 MB	56.7 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.472	2.518	⚠️ +0.05
/ avg req/sec	1011.2	992.97	⚠️ -18.23
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.498	1.503	0
/error-in-render avg req/sec	1668.87	1663.01	⚠️ -5.86

Client Bundles (main, webpack, commons)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..cf8c.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-0109a22..a8e8.js gzip	7.08 kB	7.08 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.3 kB	57.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..dule.js gzip	6.4 kB	6.4 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8b2bf21..dule.js gzip	6.14 kB	6.14 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.3 kB	52.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
index.html gzip	969 B	969 B	✓
link.html gzip	977 B	977 B	✓
withRouter.html gzip	963 B	963 B	✓
Overall change	2.91 kB	2.91 kB	✓

Serverless Mode

General

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
buildDuration	14.6s	14.3s	-322ms
nodeModulesSize	56.7 MB	56.7 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..cf8c.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-0109a22..a8e8.js gzip	7.08 kB	7.08 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.3 kB	57.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
677f882d2ed8..dule.js gzip	6.4 kB	6.4 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8b2bf21..dule.js gzip	6.14 kB	6.14 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.3 kB	52.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	merceyz/next.js merceyz/examples-names	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.22 kB	4.22 kB	✓
hooks.html	3.86 kB	3.86 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.08 MB	1.08 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.29 MB	5.29 MB	✓

Commit: 5d0b68d

**What's the problem this PR addresses?** A decent amount of the examples don't have a `name` field in `package.json` that matches their folder name, meaning they either lack a name or the names are duplicated. I was testing Yarn 2 workspaces using the entire examples directory and needed to get rid of the duplicates. **How did you fix it?** Updated the names to match the names of their folders

chore: update example names to match their folders

a80ca7d

merceyz requested review from chibicode, ijjk, lfades, Timer and timneutkens as code owners August 17, 2020 18:46

ijjk added the examples Issue/PR related to examples label Aug 17, 2020

lfades previously approved these changes Aug 17, 2020

View reviewed changes

merceyz added 2 commits August 17, 2020 20:50

fix: correct invalid semver range

7dff2b9

chore: deduplicate with-stencil name

74d5c47

merceyz dismissed lfades’s stale review via 74d5c47 August 17, 2020 18:51

lfades reviewed Aug 17, 2020

View reviewed changes

examples/with-stencil/packages/web-app/package.json Outdated Show resolved Hide resolved

chore: format packages

2c34f37

Merge branch 'canary' into merceyz/examples-names

3d093ca

lfades reviewed Sep 2, 2020

View reviewed changes

examples/with-stomp/package.json Show resolved Hide resolved

merceyz added 2 commits September 4, 2020 18:17

Merge branch 'canary' into merceyz/examples-names

859668d

chore: update stencil example name

555a7a9

Merge branch 'canary' into merceyz/examples-names

995f721

lfades approved these changes Sep 5, 2020

View reviewed changes

Merge branch 'canary' into merceyz/examples-names

5d0b68d

kodiakhq bot merged commit 2acb53b into vercel:canary Sep 5, 2020

merceyz deleted the merceyz/examples-names branch September 5, 2020 21:44

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update example names to match their folders #16268

chore: update example names to match their folders #16268

merceyz commented Aug 17, 2020

lfades left a comment

merceyz commented Aug 17, 2020

ijjk commented Aug 17, 2020

ijjk commented Aug 17, 2020

ijjk commented Aug 17, 2020

ijjk commented Aug 22, 2020

lfades commented Sep 2, 2020

ijjk commented Sep 4, 2020

ijjk commented Sep 4, 2020

merceyz commented Sep 4, 2020

ijjk commented Sep 4, 2020

lfades left a comment

ijjk commented Sep 5, 2020

chore: update example names to match their folders #16268

chore: update example names to match their folders #16268

Conversation

merceyz commented Aug 17, 2020

lfades left a comment

Choose a reason for hiding this comment

merceyz commented Aug 17, 2020

ijjk commented Aug 17, 2020

Stats from current PR

ijjk commented Aug 17, 2020

Stats from current PR

ijjk commented Aug 17, 2020

Stats from current PR

ijjk commented Aug 22, 2020

Stats from current PR

lfades commented Sep 2, 2020

ijjk commented Sep 4, 2020

Stats from current PR

ijjk commented Sep 4, 2020

Stats from current PR

merceyz commented Sep 4, 2020

ijjk commented Sep 4, 2020

Stats from current PR

lfades left a comment

Choose a reason for hiding this comment

ijjk commented Sep 5, 2020

Stats from current PR