Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples] Fix using-preact dev mode issues #14098

Merged
merged 2 commits into from
Jun 12, 2020
Merged

[Examples] Fix using-preact dev mode issues #14098

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d825704
[Examples] Fix using-preact dev mode issues
developit Jun 11, 2020
fbb657c
Merge branch 'canary' into patch-8
kodiakhq[bot] Jun 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions examples/using-preact/next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,8 @@ module.exports = withPrefresh({
const test = /[\\/]node_modules[\\/](preact|preact-render-to-string|preact-context-provider)[\\/]/
if (cacheGroups.framework) {
cacheGroups.preact = Object.assign({}, cacheGroups.framework, { test })
cacheGroups.commons.name = 'framework'
} else {
cacheGroups.preact = { name: 'commons', chunks: 'all', test }
// if you want to merge the 2 small commons+framework chunks:
// cacheGroups.commons.name = 'framework';
}
}

Expand Down