Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Examples] Fix using-preact dev mode issues #14098

Merged
merged 2 commits into from
Jun 12, 2020
Merged

[Examples] Fix using-preact dev mode issues #14098

merged 2 commits into from
Jun 12, 2020

Conversation

developit
Copy link
Contributor

Should fix #13976 (comment)

/cc @monsonjeremy - let me know if this work for you.

@ijjk ijjk added the examples Issue was opened via the examples template. label Jun 11, 2020
@ijjk
Copy link
Member

ijjk commented Jun 11, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary developit/next.js patch-8 Change
buildDuration 13.3s 13.1s -260ms
nodeModulesSize 65.2 MB 65.2 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary developit/next.js patch-8 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.236 2.236 ✓
/ avg req/sec 1117.88 1118.16 ⚠️ +0.28
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.511 1.52 ⚠️ +0.01
/error-in-render avg req/sec 1655 1645.18 -9.82
Client Bundles (main, webpack, commons)
vercel/next.js canary developit/next.js patch-8 Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary developit/next.js patch-8 Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary developit/next.js patch-8 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary developit/next.js patch-8 Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary developit/next.js patch-8 Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary developit/next.js patch-8 Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 275 B 275 B ✓
Overall change 545 B 545 B ✓
Rendered Page Sizes
vercel/next.js canary developit/next.js patch-8 Change
index.html gzip 954 B 954 B ✓
link.html gzip 961 B 961 B ✓
withRouter.html gzip 947 B 947 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary developit/next.js patch-8 Change
buildDuration 14.4s 14.3s -47ms
nodeModulesSize 65.2 MB 65.2 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary developit/next.js patch-8 Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary developit/next.js patch-8 Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary developit/next.js patch-8 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary developit/next.js patch-8 Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary developit/next.js patch-8 Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary developit/next.js patch-8 Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 275 B 275 B ✓
Overall change 545 B 545 B ✓
Serverless bundles
vercel/next.js canary developit/next.js patch-8 Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 875 kB 875 kB ✓
link.js 913 kB 913 kB ✓
routerDirect.js 905 kB 905 kB ✓
withRouter.js 905 kB 905 kB ✓
Overall change 4.48 MB 4.48 MB ✓

@ijjk
Copy link
Member

ijjk commented Jun 12, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary developit/next.js patch-8 Change
buildDuration 12.2s 12s -161ms
nodeModulesSize 65.2 MB 65.2 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary developit/next.js patch-8 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.151 2.156 ⚠️ +0.01
/ avg req/sec 1162.39 1159.68 -2.71
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.364 1.353 -0.01
/error-in-render avg req/sec 1832.57 1848.01 ⚠️ +15.44
Client Bundles (main, webpack, commons)
vercel/next.js canary developit/next.js patch-8 Change
main-HASH.js gzip 6.51 kB 6.51 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary developit/next.js patch-8 Change
main-HASH.module.js gzip 5.6 kB 5.6 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary developit/next.js patch-8 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary developit/next.js patch-8 Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
_error.js gzip 3.37 kB 3.37 kB ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
Overall change 8.34 kB 8.34 kB ✓
Client Pages Modern
vercel/next.js canary developit/next.js patch-8 Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
hooks.module.js gzip 383 B 383 B ✓
_error.module.js gzip 2.21 kB 2.21 kB ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.49 kB 5.49 kB ✓
Client Build Manifests
vercel/next.js canary developit/next.js patch-8 Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 274 B 274 B ✓
Overall change 544 B 544 B ✓
Rendered Page Sizes
vercel/next.js canary developit/next.js patch-8 Change
index.html gzip 957 B 957 B ✓
link.html gzip 963 B 963 B ✓
withRouter.html gzip 951 B 951 B ✓
Overall change 2.87 kB 2.87 kB ✓
Serverless Mode
General
vercel/next.js canary developit/next.js patch-8 Change
buildDuration 13.3s 13.2s -80ms
nodeModulesSize 65.2 MB 65.2 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary developit/next.js patch-8 Change
main-HASH.js gzip 6.51 kB 6.51 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary developit/next.js patch-8 Change
main-HASH.module.js gzip 5.6 kB 5.6 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary developit/next.js patch-8 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary developit/next.js patch-8 Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
_error.js gzip 3.37 kB 3.37 kB ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
Overall change 8.34 kB 8.34 kB ✓
Client Pages Modern
vercel/next.js canary developit/next.js patch-8 Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
hooks.module.js gzip 383 B 383 B ✓
_error.module.js gzip 2.21 kB 2.21 kB ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.49 kB 5.49 kB ✓
Client Build Manifests
vercel/next.js canary developit/next.js patch-8 Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 274 B 274 B ✓
Overall change 544 B 544 B ✓
Serverless bundles
vercel/next.js canary developit/next.js patch-8 Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 875 kB 875 kB ✓
link.js 913 kB 913 kB ✓
routerDirect.js 905 kB 905 kB ✓
withRouter.js 905 kB 905 kB ✓
Overall change 4.48 MB 4.48 MB ✓

@kodiakhq kodiakhq bot merged commit d23c22c into vercel:canary Jun 12, 2020
darshkpatel pushed a commit to MLH-Fellowship/next.js that referenced this pull request Jun 12, 2020
@developit @darshkpatel
[Examples] Fix using-preact dev mode issues (vercel#14098)
7a4aeac 
Should fix vercel#13976 (comment)

/cc @monsonjeremy - let me know if this work for you.
@ndom91 ndom91 mentioned this pull request Jun 22, 2020
Closed
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@developit @rokinsky
[Examples] Fix using-preact dev mode issues (vercel#14098)
378e06b 
Should fix vercel#13976 (comment)

/cc @monsonjeremy - let me know if this work for you.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@developit @ijjk @Timer