Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satori version outdated in @vercel/og + next/og #72940

Closed
MattIPv4 opened this issue Nov 19, 2024 · 0 comments · Fixed by #72954
Closed

Satori version outdated in @vercel/og + next/og #72940

MattIPv4 opened this issue Nov 19, 2024 · 0 comments · Fixed by #72954
Labels
bug Issue was opened via the bug report template. linear: next Confirmed issue that is tracked by the Next.js team. Upstream Related to using Next.js with a third-party dependency. (e.g., React, UI/icon libraries, etc.).

Comments

@MattIPv4
Copy link
Contributor

MattIPv4 commented Nov 19, 2024

Link to the code that reproduces this issue

https://codesandbox.io/p/devbox/nervous-glitter-3vhlqg?workspaceId=5cf2fef3-087d-4195-b1cf-506a16461a5e

To Reproduce

https://www.npmjs.com/package/@vercel/og?activeTab=code indicates the Satori version included in @vercel/og is 0.10.9. https://github.com/vercel/satori/releases indicates the most recent version of Satori is 0.11.3

To reproduce the bug that I'm concerned by, demonstrating why Satori needs to be updated:

  • Access the sandbox provided above + ensure the app is started
  • Access /api/image
  • Observe red background missing from the "does not work" div that is toward the middle of the image
  • Compare to OG Playground where the Satori fix is present

Current vs. Expected behavior

vercel/satori#565 was fixed in Satori, but the fixed version has not been propagated to @vercel/og and therefor next/og.

I could not find the source for @vercel/og to open a PR with a version bump myself. Is this package not OSS?

Provide environment information

N/A, see CodeSandbox. This is just an issue for the fact the version of a package is outdated.

Which area(s) are affected? (Select all that apply)

Upstream

Which stage(s) are affected? (Select all that apply)

next dev (local), next build (local), next start (local), Vercel (Deployed), Other (Deployed)

Additional context

No response

@MattIPv4 MattIPv4 added the bug Issue was opened via the bug report template. label Nov 19, 2024
@github-actions github-actions bot added the Upstream Related to using Next.js with a third-party dependency. (e.g., React, UI/icon libraries, etc.). label Nov 19, 2024
@samcx samcx added the linear: next Confirmed issue that is tracked by the Next.js team. label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue was opened via the bug report template. linear: next Confirmed issue that is tracked by the Next.js team. Upstream Related to using Next.js with a third-party dependency. (e.g., React, UI/icon libraries, etc.).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants