Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next dev --turbo only correctly compiles one route group having multiple root layouts in each of them #57727

Closed
1 task done
r4zendev opened this issue Oct 30, 2023 · 3 comments
Labels
bug Issue was opened via the bug report template. locked Turbopack Related to Turbopack with Next.js.

Comments

@r4zendev
Copy link

Link to the code that reproduces this issue

https://github.com/razenization/turbo-bug-repro

To Reproduce

  1. Start the application using pnpm dev (next dev --turbo)
  2. Try to visit test1, test2 routes
  3. Notice how one of them (for me in particular it was test2) renders successfully, while the other one fails to compile and throws weird error in the console saying that some DOM operations failed
  4. Try removing the --turbo flag and see how things are back to normal

Current vs. Expected behavior

I expected to be able to visit both test1 and test2 routes successfully, while having two separate root layouts in two route groups. This setup works if application is started without using the --turbo flag and I am able to open both routes.

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 21.6.0: Sat Jun 18 17:07:28 PDT 2022; root:xnu-8020.140.41~1/RELEASE_ARM64_T8110
Binaries:
  Node: 20.7.0
  npm: 10.1.0
  Yarn: N/A
  pnpm: 8.7.5
Relevant Packages:
  next: 14.0.0
  eslint-config-next: N/A
  react: 18.2.0
  react-dom: 18.2.0
  typescript: 4.6.4
Next.js Config:
  output: N/A

Which area(s) are affected? (Select all that apply)

App Router, Turbopack (--turbo)

Additional context

I have installed a template using create-next-app and attempted to use --turbo for compiling the application with slight changes to use multiple root layouts. The exact same setup works without --turbo flag. Same scenario applies to latest canary release.

@r4zendev r4zendev added the bug Issue was opened via the bug report template. label Oct 30, 2023
@github-actions github-actions bot added the Turbopack Related to Turbopack with Next.js. label Oct 30, 2023
@r4zendev
Copy link
Author

r4zendev commented Oct 30, 2023

Seems like it got fixed with v14.0.1. Can someone from the team confirm? I believe #57647 addresses that. I am not facing this issue anymore after upgrading, so feel free to close if that was intentional.

@ForsakenHarmony
Copy link
Contributor

@razenization yes this should be fixed with #57647

Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

No branches or pull requests

2 participants