Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic imports in _app.js do not hot reload #4629

Closed
morgs32 opened this issue Jun 19, 2018 · 0 comments · Fixed by #4639
Closed

Dynamic imports in _app.js do not hot reload #4629

morgs32 opened this issue Jun 19, 2018 · 0 comments · Fixed by #4639

Comments

@morgs32
Copy link

morgs32 commented Jun 19, 2018

Bug report

Dynamic imports in _app.js do not hot reload

Describe the bug

When using an _app.js file, which includes a dynamic import (using next/dynamic), changes to the dynamically imported file will not hot reload

To Reproduce

  1. Go to morgs32/with-dynamic-imports
  2. This is a variation of a pre-existing nextjs example
  3. Follow steps in Readme.md

Expected behavior

The expected behavior is changes to a dynamically imported component will hot reload (as they do in pages)

System information

  • OS: macOS
  • Version of Next.js: 6.0.3
@timneutkens timneutkens mentioned this issue Jul 25, 2018
Merged
23 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Webpack 4, react-error-overlay, react-loadable (major) timneutkens/next.js
2 participants
@morgs32 @timneutkens