Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrites failing after deployment #21642

Closed
PepijnSenders opened this issue Jan 28, 2021 · 8 comments
Closed

Rewrites failing after deployment #21642

PepijnSenders opened this issue Jan 28, 2021 · 8 comments
Milestone

Comments

@PepijnSenders
Copy link
Contributor

PepijnSenders commented Jan 28, 2021

What version of Next.js are you using?

10.0.5

What version of Node.js are you using?

15

What browser are you using?

Chrome

What operating system are you using?

macOS

How are you deploying your application?

K8S

Describe the Bug

Each time after deploying we have a small blip of rewrites failing. It looks like next.js is redirecting users to the rewritten URL which then causes a 404.

Expected Behavior

For users never to be redirected to the rewritten URL's.

To Reproduce

I'm not sure how to reproduce this yet, working on that case. But our rewrites look something like:

{
  source: "/plans",
  destination: "/legacy/funnel-fragment/plans"
}

ELB logs of people going to the pages that yield a 404 (/legacy/funnel-fragment/plans) and all other pages that have a rewrite enabled. As you can see it started happening on Jan 21, which is when we upgraded from [email protected] to [email protected].

Screen Shot 2021-01-28 at 5 10 17 PM

@PepijnSenders PepijnSenders added the bug Issue was opened via the bug report template. label Jan 28, 2021
@PepijnSenders
Copy link
Contributor Author

I feel like this PR might be fixing it: #21410, but need to test it still.

@PepijnSenders
Copy link
Contributor Author

Reverting back to 10.0.3 fixed this issue. Would be great to look at this though because we wanted to use the optimizations to next/image!

@PepijnSenders
Copy link
Contributor Author

PepijnSenders commented Feb 1, 2021

As you can see it doesn't happen anymore since reverting back to 10.0.3. For a test I blocked the _next/data URL's and it recovers perfectly with this version. With 10.0.5 it forgets the rewrites.

Screen Shot 2021-02-01 at 10 30 13 AM

@Timer Timer added kind: bug and removed bug Issue was opened via the bug report template. labels Feb 11, 2021
@Timer Timer added this to the iteration 16 milestone Feb 11, 2021
@ijjk
Copy link
Member

ijjk commented Feb 11, 2021

Hi, can you narrow in on a more specific version or provide additional details as this is hard to investigate without a reproduction and such a wide version bump since lots of changes are made between v10.0.3 and v10.0.5

@PepijnSenders
Copy link
Contributor Author

@ijjk You mean testing if it also happens in 10.0.4? I could also check if it has perhaps been fixed in latest already.

@ijjk
Copy link
Member

ijjk commented Feb 11, 2021

If you could narrow it down to a specific canary that would help the most as it would narrow down the changes a lot, also checking the latest version would definitely be good 👍

@PepijnSenders
Copy link
Contributor Author

Seems like it works again in the last canary. I guess I'll leave it up to you guys why 10.0.5 is broken, might be smart to deprecate that version because for us it was quite critical as you can see in the graphs.

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants