Broken build on `9.5.4` #17701

nfantone · 2020-10-07T21:28:20Z

Bug report

Describe the bug

After upgrading to 9.5.4 from 9.5.3, next build is no longer working for me. I'm also using [email protected] + postcss.

To Reproduce

# Running on `9.5.3` (works fine)
yarn dev

$ cross-env NEXT_TELEMETRY_DISABLED=1 NODE_ENV=development next -p 8090
info  - Loaded env from /dev/project/.env.local
ready - started server on http://localhost:8090

risk - There are upcoming breaking changes: removeDeprecatedGapUtilities, purgeLayersByDefault
risk - We highly recommend opting-in to these changes now to simplify upgrading Tailwind in the future.
risk - https://tailwindcss.com/docs/upcoming-changes
event - compiled successfully

# Upgrade to `9.5.4` and try again
rm yarn.lock
yarn add next@latest
yarn dev

$ cross-env NEXT_TELEMETRY_DISABLED=1 NODE_ENV=development next -p 8090
info  - Loaded env from /dev/project/.env.local
ready - started server on http://localhost:8090

risk - There are upcoming breaking changes: removeDeprecatedGapUtilities, purgeLayersByDefault
risk - We highly recommend opting-in to these changes now to simplify upgrading Tailwind in the future.
risk - https://tailwindcss.com/docs/upcoming-changes
error - ./src/styles/core.css (./node_modules/next/node_modules/css-loader/dist/cjs.js??ref--5-oneOf-6-1!./node_modules/next/dist/compiled/postcss-loader??__nextjs_postcss!./src/styles/core.css)
Error: Can't resolve '/fonts/la-brands-400-98099f67.eot' in '/dev/project/src/styles'
event - build page: /_error
wait  - compiling...
error - ./src/styles/core.css (./node_modules/next/node_modules/css-loader/dist/cjs.js??ref--5-oneOf-6-1!./node_modules/next/dist/compiled/postcss-loader??__nextjs_postcss!./src/styles/core.css)
Error: Can't resolve '/fonts/la-brands-400-98099f67.eot' in '/dev/project/src/styles'
Error: Cannot find module '/dev/project/.next/build-manifest.json'

Then it starts looping on a `MODULE_NOT_FOUND` exception

Require stack:
- /dev/project/node_modules/next/dist/next-server/server/load-components.js
- /dev/project/node_modules/next/dist/next-server/server/api-utils.js
- /dev/project/node_modules/next/dist/next-server/server/next-server.js
- /dev/project/node_modules/next/dist/server/next.js
- /dev/project/node_modules/next/dist/server/lib/start-server.js
- /dev/project/node_modules/next/dist/cli/next-dev.js
- /dev/project/node_modules/next/dist/bin/next
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:831:15)
    at Function.Module._load (internal/modules/cjs/loader.js:687:27)
    at Module.require (internal/modules/cjs/loader.js:903:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at loadComponents (/dev/project/node_modules/next/dist/next-server/server/load-components.js:1:886)
    at DevServer.findPageComponents (/dev/project/node_modules/next/dist/next-server/server/next-server.js:54:189)
    at DevServer.renderErrorToHTML (/dev/project/node_modules/next/dist/next-server/server/next-server.js:103:114)
    at DevServer.renderErrorToHTML (/dev/project/node_modules/next/dist/server/next-dev-server.js:34:974)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/dev/project/node_modules/next/dist/next-server/server/load-components.js',
    '/dev/project/node_modules/next/dist/next-server/server/api-utils.js',
    '/dev/project/node_modules/next/dist/next-server/server/next-server.js',
    '/dev/project/node_modules/next/dist/server/next.js',
    '/dev/project/node_modules/next/dist/server/lib/start-server.js',
    '/dev/project/node_modules/next/dist/cli/next-dev.js',
    '/dev/project/node_modules/next/dist/bin/next'
  ]
}

Expected behavior

Build should continue to work. No other change was introduced in the failing project.

Reverting back to 9.5.3 solves the issue.
The file it's complaining about (/fonts/la-brands-400-98099f67.eot) it's actually there and has always been.
next build fails with the exact same error.

System information

OS: macOS 10.15.7 (19H2)
Version of Next.js: 9.5.4
Version of Node.js: v12.19.0

The text was updated successfully, but these errors were encountered:

ijjk · 2020-10-07T22:16:33Z

~~Hi, I'm not able to reproduce on a minimal project with Next.js v9.5.4 and tailwindcss v1.8.12. Can you provide a repo with a minimal reproduction so we can investigate this further?~~

Looks like minimal reproduction is using url() to a non-relative file in a CSS/SCSS file

After investigation this seems to be from breaking changes in v4.0.0 of css-loader which was updated in #16973

spencewood · 2020-10-07T22:27:12Z

I am also running into this issue after upgrade. The problem seems to lie in importing fonts via url:

@font-face {
  font-family: "somefont";
  src: url("/fonts/some-font.eot"); /* from public directory */
}

It previously could find fonts on 9.5.3, but with 9.5.4 the css-loader cannot find these paths.

UncleClapton · 2020-10-07T22:32:41Z

I have this error in my css as well.

using this @font-face config:

@font-face {
  font-display: swap;
  font-family: 'Open Sans';
  font-style: normal;
  font-weight: normal;
  src: local('Open Sans Regular'), local('OpenSans-Regular'), url('/static/fonts/OpenSans/OpenSans-Regular.ttf') format('truetype');
}

with the ttf file being located at <project_root>/public/static/fonts/OpenSans/OpenSans-Regular.ttf. results in the following error:

error - ./src/scss/app.scss (./node_modules/css-loader/dist/cjs.js??ref--6-oneOf-7-1!./node_modules/next/dist/compiled/postcss-loader??__nextjs_postcss!./node_modules/resolve-url-loader??ref--6-oneOf-7-3!./node_modules/sass-loader/dist/cjs.js??ref--6-oneOf-7-4!./src/scss/app.scss)
Error: Can't resolve '/static/fonts/OpenSans/OpenSans-Regular.ttf' in '<project_root>/src/scss'

9.5.3 does not give this error.

nfantone · 2020-10-07T23:02:51Z

Confirmed. Exactly my case. Thanks @UncleClapton and @spencewood for jumping in.

mjr · 2020-10-08T01:25:35Z

Minimal reproduction repo.

https://codesandbox.io/s/great-margulis-m5tmn

@ijjk

OlehDutchenko · 2020-10-08T07:45:33Z

Faced with same error

Error: Can't resolve '/pic/decor-top.svg'

I guess problem in updated sass-loader after #16970

flayks · 2020-10-08T07:52:34Z

Same issues with loading fonts in SCSS files:
Error: Can't resolve '/fonts/sans-regular.woff2' in '/Users/xxx/sites/xxx/styles'

flayks · 2020-10-08T07:56:12Z

I changed my SCSS variables (responsible for importing files) from "/directory" to "/public/directory" and it seems to fix the problem (for now at least) 👀

/* Directories
========================================================================== */
$dir-img: "/public/images";
$dir-fonts: "/public/fonts";

OlehDutchenko · 2020-10-08T08:11:26Z

I cannot understand, why compiler trying to resolve absolute urls?
for inlining file in JS?

@flayks if hack with /public/images works - that meens that loader inlining files...

but I do not need this. I just want to use background: url('/path/to/my-file.ext') in normall CSS way.

RobbyUitbeijerse · 2020-10-08T09:09:59Z

Downgrading css-loader to 3.6.0 locally does resolve the issue, so #16970 indeed seems to be the cause (as mentioned by @dutchenkoOleg)

[edit] it actually seems to be intended: webpack-contrib/css-loader#1153 (comment)

OlehDutchenko · 2020-10-08T09:14:51Z

or #16973 (@ijjk reported earler)

nfantone · 2020-10-08T09:20:40Z

Is sass-loader affecting css-loader? For the record, I'm not using SASS on my originally broken project.

Regardless, the release notes for the bumped sass-loader version say:

Bug Fixes

handle absolute windows path in source maps

So it'd make sense to be related to this.

EDIT

I see that #16973, as pointed out by @dutchenkoOleg does change css-loader version.

timneutkens · 2020-10-08T09:25:09Z

Let's stop spamming this issue as the root cause has been highlighted.

As @ijjk said it's related to css-loader being upgraded. @ijjk will work on a fix today.

This reverts commit 7e15a57 See: vercel/next.js#17701

This is a follow-up to #16973 which adds handling for the breaking change in the latest version of css-loader that causes unresolved file references in `url` or `import` to cause the build to fail. This fixes it by adding our own resolve checking and when it fails disabling the `css-loader`'s handling of it. Fixes: #17701

ijjk · 2020-10-08T21:21:23Z

Hi, this should be corrected in the latest canary of Next.js v9.5.5-canary.0, please upgrade and give it a try!

OlehDutchenko · 2020-10-09T09:19:07Z

It's alive!
Thanks

nfantone · 2020-10-09T11:54:26Z

Working great for me, as well! Thanks so much @ijjk.

pkellner · 2020-10-09T20:42:40Z

I know you guys are all over this issue, but ... I'm getting hammered with folks using my courses on Pluralsight and the examples are now completely dead. It's no different then your with-tailwindcss example when I add to the styles/index.css a simple class definition like this:

.heartredbutton {
  background-image: url('/heart-red.png');
}

and it expects to pick up the file from the /public folder. Instead, the app crashes with

error - ./styles/index.css (./node_modules/css-loader/dist/cjs.js??ref--5-oneOf-6-1!./node_modules/next/dist/compiled/postcss-loader??__nextjs_postcss!./styles/index.css)

Is there a work-a-round I can give people? Will this magically start working? I have in my package.json 9.5.4 for next version.

timneutkens · 2020-10-09T20:46:04Z

#17701 (comment)

You can use yarn add next@canary to use the latest canary release. A new release will be published later today.

OlehDutchenko · 2020-10-09T20:46:48Z

@pkellner install canary version

npm i next@canary

pkellner · 2020-10-09T21:29:30Z

Thanks @timneutkens , I'm sure I have lots of other people with breaking builds who just think I uploaded broken source. When I update my package.json file to "next": "^9.5.5-canary.0", the error goes away.

Should I immediately update all my example package.json entries to that 9.5.5 canary? Will 9.5.4 magically start working after something changes in next? I appreciate the fast work around but the next step for me is very important as I'm sure there are at least 50 people out there who are doing my demos saying WTF?

Also, had I left a package-lock.json out there, would that have avoided all this? I don't ever check that lock file into my examples repo following the example of how Next setups up there examples repo (which also is broken right now)

ijjk · 2020-10-10T00:50:10Z

Hi, a new patch release v9.5.5 has been published which contains the fix for this issue

pkellner · 2020-10-10T01:59:55Z

It's totally an anti-pattern to leave "thank you" on an issue because it adds no value. But... @ijjk @timneutkens ... THANK YOU

This reverts commit ec8e4626 See: vercel/next.js#17701

This reverts commit ec8e462 See: vercel/next.js#17701

balazsorban44 · 2022-01-29T10:05:25Z

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

ijjk added the please add a complete reproduction The issue lacks information for further investigation label Oct 7, 2020

ijjk added kind: bug and removed please add a complete reproduction The issue lacks information for further investigation labels Oct 7, 2020

timneutkens added the priority: p0 label Oct 8, 2020

mrtnzlml added a commit to mrtnzlml-archive/kochka.com.mx that referenced this issue Oct 8, 2020

Revert "Bump next from 9.5.3 to 9.5.4"

498288a

This reverts commit 7e15a57 See: vercel/next.js#17701

mrtnzlml mentioned this issue Oct 8, 2020

[security] build(deps): bump next from 9.5.3 to 9.5.4 adeira/universe#1123

Closed

ijjk mentioned this issue Oct 8, 2020

Handle css-loader file resolving change #17724

Merged

ijjk self-assigned this Oct 8, 2020

ijjk added the point: 2 label Oct 8, 2020

kodiakhq bot closed this as completed in #17724 Oct 8, 2020

timneutkens mentioned this issue Oct 8, 2020

Static Assets breaking in 9.5.4 #17728

Closed

ijjk mentioned this issue Oct 9, 2020

Upgrade to 9.5.4 broke CSS url loading #17734

Closed

mrtnzlml mentioned this issue Oct 9, 2020

Bump next from 9.5.3 to 9.5.4 mrtnzlml-archive/kochka.com.mx#32

Closed

madsfaerch mentioned this issue Oct 9, 2020

next build wont work after updating from [email protected] to [email protected] #17744

Closed

mduleone mentioned this issue Oct 9, 2020

Next 9.5.4: Loading fonts from internal source breaks #17751

Closed

ijjk mentioned this issue Oct 9, 2020

Next 9.5.3 -> 9.5.4 breaks local asset (font/image) resolution #17756

Closed

This was referenced Oct 12, 2020

Bump next from 9.5.2 to 9.5.4 minvws/nl-covid19-data-dashboard#572

Closed

Bump next from 9.5.2 to 9.5.5 minvws/nl-covid19-data-dashboard#574

Merged

mrtnzlml added a commit to adeira/universe that referenced this issue Mar 19, 2021

Revert "Bump next from 9.5.3 to 9.5.4"

cd3d778

This reverts commit ec8e4626 See: vercel/next.js#17701

kodiakhq bot pushed a commit to adeira/universe that referenced this issue Mar 20, 2021

Revert "Bump next from 9.5.3 to 9.5.4"

09f052c

This reverts commit ec8e4626 See: vercel/next.js#17701

mrtnzlml added a commit to mrtnzlml-archive/kochka.com.mx that referenced this issue May 4, 2021

Revert "Bump next from 9.5.3 to 9.5.4"

7a41c9a

This reverts commit ec8e462 See: vercel/next.js#17701

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Broken build on `9.5.4` #17701

Broken build on `9.5.4` #17701

nfantone commented Oct 7, 2020 •

edited

Loading

ijjk commented Oct 7, 2020 •

edited

Loading

spencewood commented Oct 7, 2020

UncleClapton commented Oct 7, 2020 •

edited

Loading

nfantone commented Oct 7, 2020

mjr commented Oct 8, 2020 •

edited

Loading

OlehDutchenko commented Oct 8, 2020

flayks commented Oct 8, 2020

flayks commented Oct 8, 2020

OlehDutchenko commented Oct 8, 2020

RobbyUitbeijerse commented Oct 8, 2020 •

edited

Loading

OlehDutchenko commented Oct 8, 2020

nfantone commented Oct 8, 2020 •

edited

Loading

timneutkens commented Oct 8, 2020 •

edited

Loading

ijjk commented Oct 8, 2020

OlehDutchenko commented Oct 9, 2020

nfantone commented Oct 9, 2020

pkellner commented Oct 9, 2020

timneutkens commented Oct 9, 2020 •

edited

Loading

OlehDutchenko commented Oct 9, 2020

pkellner commented Oct 9, 2020 •

edited

Loading

ijjk commented Oct 10, 2020

pkellner commented Oct 10, 2020

balazsorban44 commented Jan 29, 2022

Broken build on 9.5.4 #17701

Broken build on 9.5.4 #17701

Comments

nfantone commented Oct 7, 2020 • edited Loading

Bug report

Describe the bug

To Reproduce

Expected behavior

System information

ijjk commented Oct 7, 2020 • edited Loading

spencewood commented Oct 7, 2020

UncleClapton commented Oct 7, 2020 • edited Loading

nfantone commented Oct 7, 2020

mjr commented Oct 8, 2020 • edited Loading

OlehDutchenko commented Oct 8, 2020

flayks commented Oct 8, 2020

flayks commented Oct 8, 2020

OlehDutchenko commented Oct 8, 2020

RobbyUitbeijerse commented Oct 8, 2020 • edited Loading

OlehDutchenko commented Oct 8, 2020

nfantone commented Oct 8, 2020 • edited Loading

timneutkens commented Oct 8, 2020 • edited Loading

ijjk commented Oct 8, 2020

OlehDutchenko commented Oct 9, 2020

nfantone commented Oct 9, 2020

pkellner commented Oct 9, 2020

timneutkens commented Oct 9, 2020 • edited Loading

OlehDutchenko commented Oct 9, 2020

pkellner commented Oct 9, 2020 • edited Loading

ijjk commented Oct 10, 2020

pkellner commented Oct 10, 2020

balazsorban44 commented Jan 29, 2022

Broken build on `9.5.4` #17701

Broken build on `9.5.4` #17701

nfantone commented Oct 7, 2020 •

edited

Loading

ijjk commented Oct 7, 2020 •

edited

Loading

UncleClapton commented Oct 7, 2020 •

edited

Loading

mjr commented Oct 8, 2020 •

edited

Loading

RobbyUitbeijerse commented Oct 8, 2020 •

edited

Loading

nfantone commented Oct 8, 2020 •

edited

Loading

timneutkens commented Oct 8, 2020 •

edited

Loading

timneutkens commented Oct 9, 2020 •

edited

Loading

pkellner commented Oct 9, 2020 •

edited

Loading