with-redux-wrapper example bug

[zhangwei900808]

Bug report

Describe the bug

In with-redux-wrapper example index.js page has a code:

export const getStaticProps = wrapper.getStaticProps(async ({ store }) => {
  store.dispatch(serverRenderClock(true))
  store.dispatch(addCount())
})

the reducer.js

import { countActionTypes } from './action'

const countInitialState = {
  count: 0,
}

export default function reducer(state = countInitialState, action) {
  switch (action.type) {
    case countActionTypes.ADD:
      return Object.assign({}, state, {
        count: state.count + 1,
      })
    default:
      return state
  }
}

in getStaticProps code has store.dispatch(addCount())
so when I run the index.js page the page count must be 1 but is 0 is bug?

[Pitasi]

Hi, I found the problem here: https://github.com/vercel/next.js/blob/canary/examples/with-redux-wrapper/store/store.js#L26
That line should instead be:

    if (state.count.count) nextState.count.count = state.count.count // preserve count value on client side navigation

Since the first "count" key refers to the count reducer, and the second "count" key is the actual value defined in count/reducer.js. (In fact it is used correctly in AddCount.js:23).

Since it's a small change I decided to go ahead and opened a PR: #17335 😄

[zhangwei900808]

@Pitasi I try it, It work! very thank you

[balazsorban44]

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.