fix searchParams dev warning

vercel · Sep 2, 2020 · 9bf37bf · 9bf37bf
1 parent 0649176
commit 9bf37bf
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/packages/next/next-server/lib/utils.ts b/packages/next/next-server/lib/utils.ts
@@ -363,6 +363,7 @@ export const urlObjectKeys = [
   'protocol',
   'query',
   'search',
+  'searchParams',
   'slashes',
 ]
 

diff --git a/test/integration/dynamic-routing/pages/index.js b/test/integration/dynamic-routing/pages/index.js
@@ -1,6 +1,15 @@
 import Link from 'next/link'
 import { useRouter } from 'next/router'
 
+if (typeof window !== 'undefined') {
+  window.caughtWarns = []
+  const origWarn = window.console.warn
+  window.console.warn = function (...args) {
+    window.caughtWarns.push(args)
+    origWarn(...args)
+  }
+}
+
 const Page = () => {
   return (
     <div>

diff --git a/test/integration/dynamic-routing/test/index.test.js b/test/integration/dynamic-routing/test/index.test.js
@@ -84,6 +84,12 @@ function runTests(dev) {
     expect(url).toBe('?fromHome=true')
   })
 
+  it('should not have any console warnings', async () => {
+    const browser = await webdriver(appPort, '/')
+    const caughtWarns = await browser.eval(`window.caughtWarns`)
+    expect(caughtWarns).toEqual([])
+  })
+
   it('should navigate to a dynamic page successfully', async () => {
     let browser
     try {