Skip to content

Commit

Permalink
[Example] with-react-intl: fix getInitialProps props ordering (#17174)
Browse files Browse the repository at this point in the history
Invalid ordering in Promise.all and in receiving destruction.

Now appProps receives result of polyfill(supportedLocale) call.
  • Loading branch information
bacher authored Sep 21, 2020
1 parent 4f1ccda commit 231016f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion examples/with-react-intl/pages/_app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const getInitialProps: typeof App.getInitialProps = async appContext => {

const [supportedLocale, messagePromise] = getMessages(requestedLocales);

const [appProps, messages] = await Promise.all([
const [, messages, appProps] = await Promise.all([
polyfill(supportedLocale),
messagePromise,
App.getInitialProps(appContext),
Expand Down

0 comments on commit 231016f

Please sign in to comment.