Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Lear Next.js (Basic course) #633

Closed
GeorgiiGalechyan opened this issue Mar 28, 2024 · 1 comment
Closed

Docs: Lear Next.js (Basic course) #633

GeorgiiGalechyan opened this issue Mar 28, 2024 · 1 comment

Comments

@GeorgiiGalechyan
Copy link

GeorgiiGalechyan commented Mar 28, 2024

What is the improvement or update you wish to see?

Hello. Starting from this section of the documentation there is an error in the code of the Search component.
Previously, the Search component contained props placeholder and looked like this:

export default function Search({ placeholder }: { placeholder: string }) {

  //...

}

But starting from the specified place of props placeholder is missing, although it should be. Inside the component, in the input tag, placeholder={placeholder} is used, which causes an error.

export default function Search( /*there should be a placeholder here*/ ) {
 
 //...

 }

p.s. I apologize in advance for my English

Is there any context that might help us understand?

I'm just taking a basic course on next.js and found a small error. That's the whole context.

Does the docs page already exist? Please link to it.

https://nextjs.org/learn/dashboard-app/adding-search-and-pagination#2-update-the-url-with-the-search-params

@GeorgiiGalechyan GeorgiiGalechyan changed the title Docs: https://nextjs.org/learn/dashboard-app/adding-search-and-pagination Docs: Lear Next.js (Basic course) Mar 28, 2024
@balazsorban44 balazsorban44 transferred this issue from vercel/next.js Apr 2, 2024
@leerob
Copy link
Member

leerob commented Jun 23, 2024

Thank you, we have updated this since then.

@leerob leerob closed this as completed Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants