-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keymaps regression #4173
Comments
Oh, iirc this was changed after adding the mousetrap type definitions Since it only listed 1 argument of Element type (optional which defaults to document) I removed those and tested, but didn't face any issues. I see, we are using a fork of Mousetrap which adds the capture option. We can change this, and add a type declaration override in the ext-modules file. P.S. what issue is caused by this? I didn't face any. |
Some keymaps of plugins will not work. You can try |
This bug was introduced in #3957.
We need to init
Mousetrap
withtrue
as the second argument:https://github.com/zeit/hyper/blob/d5d5bcc74ca8de4c568c410fe042b5ef353baf67/lib/containers/hyper.js#L58
But we remove this argument after #3957:
https://github.com/zeit/hyper/blob/a1eb84d8a7c277ddf29d739e46cde14c4c14b4f7/lib/containers/hyper.tsx#L62
Refer: ccampbell/mousetrap#400
The text was updated successfully, but these errors were encountered: