Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZSH powerline prompt not rendering properly on hyper 3.0.0 #3617

Closed
2 tasks done
ridhwaans opened this issue May 7, 2019 · 15 comments
Closed
2 tasks done

ZSH powerline prompt not rendering properly on hyper 3.0.0 #3617

ridhwaans opened this issue May 7, 2019 · 15 comments
Labels
👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself ⚡ Type: Regression This used to work before but a recent update broke it.

Comments

@ridhwaans
Copy link

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate

Issue

image

Using zsh by default above, the powerline prompt is incorrectly showing a black line and shape at the front and back on hyper3. This change occurred after the update.

@Stanzilla Stanzilla added ⚡ Type: Regression This used to work before but a recent update broke it. 👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself labels May 7, 2019
@cahalane
Copy link

cahalane commented May 7, 2019

The problem does not appear to be Windows-specific, as I have encountered it on Ubuntu:
image

I have encountered it using both the Meslo LG M DZ for Powerline and Noto Mono for Powerline fonts.

@NathanielInman
Copy link

The problem also doesn't appear to be font-specific. I have the issue on the aforementioned fonts as well as PragmataPro on macOS.
image
image

@cahalane
Copy link

cahalane commented May 7, 2019

So for some display-related reason (maybe CSS settings for legibility, maybe the actual Electron version), the start of the actual glyph no longer aligns with the start of the background, which is a problem for any theme/font that use the  arrow, and on any OS.

@LeTrovoes
Copy link

Same issue here, on Ubuntu 18.04. This is a duplicate of #3575

@voronoipotato
Copy link

voronoipotato commented May 8, 2019

This may be related to broken ligatures in 3.0.0 #3607

@technofantods
Copy link

same issue - kubuntu 18.04

image

@cahalane
Copy link

cahalane commented May 8, 2019

Noting that #3575 lists a workaround:

This issue seems related to the WebGL rendering, as turning webGLRenderer to false in config seems to revert to hyper v2 behavior
Setting webGLRenderer: false worked for me on latest Windows 10. It also restored font ligatures (with the appropriate plugin), which were also broken by the v3 release.

The behaviour isn't perfect (there's a 1px offset in the opposite direction still) but it should help resolve some of that annoyance

@technofantods
Copy link

I dropped webGLRenderer: false, right under update channel and it worked for me

@Muzical84
Copy link

I made the change, at the top of my config, in the latest macOS, and I still have the problem. Everything looks like it should in vanilla Terminal.

@spacecowgirl314
Copy link

spacecowgirl314 commented May 12, 2019

I dropped webGLRenderer: false, right under update channel and it worked for me

Thank you! I had the same problem with my PowerShell powerline prompt. It was so irritating.

@bet4it bet4it mentioned this issue Aug 31, 2019
2 tasks
@Basster
Copy link

Basster commented Sep 29, 2019

Can confirm this issue on Ubuntu 18.04 with zsh.

webGLRenderer: false

fixes it, as well.

@Svetomechc
Copy link

@Stanzilla why was this closed? webGLRenderer: false is not a solution - it's a workaround. With webGLRenderer: true the app is much faster (you can see it when scrolling).

@Stanzilla
Copy link
Collaborator

Stanzilla commented Nov 6, 2019

It's our solution for now. until webglrenderer gets more usable.

@Muzical84
Copy link

It's not a workaround or a solution if it doesn't work. As I said above, I'm still getting boxes in macOS Mojave, and yes I have reinstalled, reloaded my config, etc. It's literally something I re-try again every few weeks because other terminal GUIs are so much harder on my eyes, but I'm stuck in iTerm2 for now.

@Stanzilla
Copy link
Collaborator

@Muzical84 well you could test one of your CI builds https://app.circleci.com/jobs/github/zeit/hyper/2923/artifacts or switch to https://github.com/Eugeny/terminus instead. It's very well maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself ⚡ Type: Regression This used to work before but a recent update broke it.
Projects
None yet
Development

No branches or pull requests