Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Compile Warning #555

Closed
robinbraibant opened this issue Aug 26, 2021 · 4 comments
Closed

PHP Compile Warning #555

robinbraibant opened this issue Aug 26, 2021 · 4 comments

Comments

@robinbraibant
Copy link

Description
When submitting a form, I get the following warning: PHP Compile Warning – yii\base\ErrorException
Private methods cannot be final as they are never overridden by other classes

This warning gets thrown by hoa/stream/Stream.php. Seems like there is something wrong with the PHP 8.0 compatibility.

Steps to reproduce
1.
2.

Form settings

Please pick from the options below.

  • Multi-page form: No
  • Submission Method: Page Reload
  • Client-side Validation: Yes
  • Custom Form Templates: Yes

Additional info

  • Plugin version: 1.4.14
  • Craft version: 3.7.10
  • Multi-site: Yes

Additional context

@engram-design
Copy link
Member

If you're on PHP 8, this is related to #525 (comment)

@engram-design
Copy link
Member

There is a PR to fix this but not looking like it'll be merged.

If you're unable to downgrade from PHP 8, you should be able to get around this issue by adding the following to your composer.json.

"require": {
    "hoa/stream": "dev-1.17.02.21-php8 as 1.17.02.21"
},
"repositories": [{
    "type": "vcs",
    "url": "https://github.com/mathroc/Stream"
}],

I'd love to include this in Formie's composer.json file, but these changes will only work in the root composer.json file - https://stackoverflow.com/questions/35699807/nested-dependencies-and-private-repositories-with-composer

@robinbraibant
Copy link
Author

Thank you for the feedback!

@engram-design
Copy link
Member

This will also be addressed in #582 with the switch out from the hoa/ruler project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants