Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinTreeNodeReader::peekInt8($offset=0): parameter $offset is unused #141

Closed
zjorzzzey opened this issue Nov 8, 2012 · 1 comment
Closed

Comments

@zjorzzzey
Copy link

the method BinTreeNodeReader::peekInt8($offset=0) always returns the int8-value at offset 0. This doesn't seem to affect the functioning of WhatsAPI as of yet, but it would be nice to have this fixed before someone unknowingly starts using it (for reference, see peekInt16 and peekInt24, these are correct).

expected result:

$sbstr = substr($this->_input, $offset, 1);    // returns the 8-bit value from offset $offset

current code:

 $sbstr = substr($this->_input, 0, 1);    // returns the first 8-bit value in the input buffer
@zstars
Copy link
Contributor

zstars commented Nov 8, 2012

Ok, added

@veno veno closed this as completed in f7f7002 Nov 8, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants