Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: Disallow querying of personal data for guest Customers #98

Closed
michaelbromley opened this issue May 16, 2019 · 1 comment
Closed

Comments

@michaelbromley
Copy link
Member

Currently it is possible to:

  1. Use setCustomerForOrder with [email protected]
  2. Query activeOrder.customer.addresses to get data on any addresses used by [email protected] in the past.

This is a security hole which would expose details of previous guest checkouts, opening the door to enumeration attacks.

Mitigation

Disallow access to the customer entity unless authenticated. Check for any other possible vectors of a similar nature.

@heri16
Copy link

heri16 commented Mar 5, 2020

This is really bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants