perf(core): Improve performance of apply-collection-filters job #915
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request will improve the performance of apply-collection-filters job.
I noticed that we use only variants ids before we reassign
collection.productVariants
inCollectionService.applyCollectionFiltersInternal
.Based on experiments the performance of the query in
CollectionService.getCollectionProductVariantIds
method will be 8x faster.