Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): Improve performance of apply-collection-filters job #915

Merged

Conversation

dkostenko-jsninja
Copy link
Contributor

Changes in this pull request will improve the performance of apply-collection-filters job.

I noticed that we use only variants ids before we reassign collection.productVariants in CollectionService.applyCollectionFiltersInternal.

Based on experiments the performance of the query in CollectionService.getCollectionProductVariantIds method will be 8x faster.

@dkostenko-jsninja dkostenko-jsninja force-pushed the acf-job-performance branch 2 times, most recently from 3c49c5e to 0210aab Compare June 2, 2021 07:37
@michaelbromley
Copy link
Member

Wow, this is great! Please could you PR against the master branch though, since this is not a feature so it can go in the next patch release :)

Verified

This commit was signed with the committer’s verified signature. The key has expired.
simonrozsival Šimon Rozsíval
@dkostenko-jsninja dkostenko-jsninja changed the base branch from minor to major June 2, 2021 12:23
@dkostenko-jsninja dkostenko-jsninja changed the base branch from major to master June 2, 2021 12:24
@dkostenko-jsninja
Copy link
Contributor Author

Hello! I've just changed the base branch.

@michaelbromley michaelbromley merged commit 1e8c137 into vendure-ecommerce:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants