wrong refund total in createRefund method

[chladog]

Describe the bug
When modifying an order to lower amount with need of a refund then in UI in the preview change and later on in the history entry it shows correct refund amount but the actual value passed to createRefund function differs and doesn't match the calculated total which then results in wrong amount being refunded and impossibile transition from "Modifying" to PaymentSettled due to: "Cannot transition Order to the "PaymentSettled" state when the total is not covered by settled Payments"
I have console logged the "amount" parameter in the payment handler createRefund function and there is the wrong amount coming in.

Note to say that we have promotion on such order (though the preview window showed correct calculation of everything).

Environment (please complete the following information):

• @vendure/core version: v1.0.0

[chladog]

could it be related to this? (was the problem/update applied for refunds as well?) 1795f48

[michaelbromley]

I can reproduce this class of error when the order has a promotion applied, and without a promotion it works as expected. Looks like I missed some code path on the modification logic. Fixing this now.