Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending the Vendure-Email-Plugin to accept the Node-mailer "content" parameter #882

Closed
Raphael-Bier opened this issue May 17, 2021 · 1 comment

Comments

@Raphael-Bier
Copy link

Is your feature request related to a problem? Please describe.
We want to use attachments alongside the Vendure-Email Plugin using Nodemailer, and we are limited in that manner by the Vendure email plugin since we currently only can use the "path" parameter and we will need to use the "content" parameter to send in a buffer.

Describe the solution you'd like
Since Nodemailer can use the following parameter "content" to pass a buffer it could be a great addition to the email plugin.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Node-Mailer documentation :
https://nodemailer.com/message/attachments/

Vendure documentation relating to the email attachments and stating that only the path parameter is available for now :
https://www.vendure.io/docs/typescript-api/email-plugin/email-event-handler/#setattachments

Feature Request suggestion on the Vendure Slack :
https://app.slack.com/client/TKY7HFU04/CKYMF0ZTJ/thread/CKYMF0ZTJ-1621233428.206000

@michaelbromley
Copy link
Member

I just realised the reason that I left out support for content as a buffer: email are send via the job queue, and all jobs get serialized when put into the job queue. But this should still be doable since I believe it is possible to serialize and deserialize buffers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants