Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in settle payment method if multtiple payment #847

Closed
ttournie opened this issue Apr 28, 2021 · 0 comments
Closed

Bug in settle payment method if multtiple payment #847

ttournie opened this issue Apr 28, 2021 · 0 comments
Assignees
@michaelbromley
Labels
type: bug 🐛 Something isn't working @vendure/core
Milestone
v1.0.0

Comments

@ttournie
Copy link
Contributor

Describe the bug
In the settlePayment method in OrderService,
the check : orderTotalSettled = payment.amount === payment.order.totalWithTax;
does not work in the case there is several payments.

To Reproduce
settle a payment after doing other payments

Expected behavior
the check should compare the amount of all the already settled payment not only the payment amount
@ttournie ttournie added the type: bug 🐛 Something isn't working label Apr 28, 2021
@michaelbromley michaelbromley added this to the v1.0.0 milestone Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelbromley michaelbromley

Labels
type: bug 🐛 Something isn't working @vendure/core
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@ttournie @michaelbromley