Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Should we purge unused strings in the i18n json files? #839

Closed
Wanztwurst opened this issue Apr 22, 2021 · 2 comments
Closed

[core] Should we purge unused strings in the i18n json files? #839

Wanztwurst opened this issue Apr 22, 2021 · 2 comments

Comments

@Wanztwurst
Copy link
Contributor

Wanztwurst commented Apr 22, 2021 •
edited
Loading

I came around strings in the translation files which don't seem to be in use currently. Are these lines to be purged?
Example: errorResult.ALREADY_CANCELLED_ERROR

Other strings are only used in the e2e and generated type files – what about those strings? Or am I wrong here and those error codes' names aren't mentioned in the code and still used somehow? Edit: Found the missing link!
@michaelbromley
Copy link
Member

Yes, that particular error code seems to no longer be used and should be deleted. Would you like to PR this?

@Wanztwurst
Copy link
Contributor Author

Yes, will do together with some improved translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelbromley @Wanztwurst