feat(core): Add ability to get variants for a specific product in productVariants query #786
Conversation
|
Hi, Could you rebase this PR onto the master branch? - there were some failing tests which I've now fixed, so then we can make sure your changes are passing in CI too. |
dkostenko-jsninja
force-pushed
the
product-variants-pagination
branch
from
cce19c7 to
11004e8
Compare
|
Hello! I've just done a rebase onto the master branch. The problem exists for any product which has hundreds of variants. |
There was a problem hiding this comment.
Generally looks good - just see my comment about a possible way to do this with less code duplication. Also, an e2e test for this would be good - do you feel confident to add one? If so it would go here
| const rawConnection = this.connection.rawConnection; | ||
| const qb = this.connection.getRepository(ctx, ProductVariant).createQueryBuilder('productvariant'); | ||
|
|
||
| const filter = parseFilterParams(rawConnection, ProductVariant, options.filter); |
There was a problem hiding this comment.
I notice that quite a significant amount of logic here is being duplicated from the ListQueryBuilder.build() method. I am wondering whether it would be possible to use the ListQueryBuilder, and then add the required clauses (ie. .andWhere('productvariant.productId = :productId', { productId }) to the returned SelectQueryBuilder object.
Did you try that approach yet?
There was a problem hiding this comment.
Hello! Thank you! I agree that would be better to use ListQueryBuilder.build() here. I will do it.
dkostenko-jsninja
force-pushed
the
product-variants-pagination
branch
from
11004e8 to
c1f5216
Compare
|
Hello! I implemented |
…ductVariants query
dkostenko-jsninja
force-pushed
the
product-variants-pagination
branch
from
c1f5216 to
0ef5a62
Compare
|
Hello! I did a rebase and replaced |
|
Thank you for your contribution! 👍 |
In Vendure we have 2 ways to receive product variants by using product and productVariants queries.
product query finds all product variants for a specific product and in case the product has a lot of variants, the performance of this query will be very slow.
productVariants query has options for pagination and filtering but by using this query we cannot receive variants only for a specific product.
Changes in this pull request will fix this problem. So, in the result, we will have the ability to fetch either all variants or only for the specific product by using the productVariants query.