Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional eligibility checks on ProductVariant in Cart/OrderLine #723

Closed
chladog opened this issue Feb 19, 2021 · 0 comments
Closed

Additional eligibility checks on ProductVariant in Cart/OrderLine #723

chladog opened this issue Feb 19, 2021 · 0 comments

Comments

@chladog
Copy link
Contributor

chladog commented Feb 19, 2021

Is your feature request related to a problem? Please describe.
Currently there are no eligibility checks when adding a ProductVariant to Order (e.g. is Product enabled? isn't Product deleted? is ProductVariant enabled? isn't ProductVariant deleted?). This can result in customer ordering invalid ProductVariant when there is some bug, or cached page, or via manual mutation query by exploiters.

Describe the solution you'd like
Check validity of such action (adding ProductVariant to Order). As well as there should be additional check when transitioning Order to next state from AddingItems that all OrderLines have eligible ProductVariants (incl. enough of stock).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants