New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discounts array in order entity is not cleared after removing the coupon code. #649

Closed

gauravagrawal1710 opened this issue Jan 12, 2021 · 0 comments

Assignees

Labels

Milestone

gauravagrawal1710 commented Jan 12, 2021

Describe the bug
Discounts array in order entity is not cleared after removing the coupon code.
To Reproduce
Steps to reproduce the behavior:

Add a coupon code to an order
The couponCodes and discounts arrays get populated with the necessary info.
Remove the coupon code.
The couponCodes array gets cleared but the discounts array doesn't get cleared.

Expected behavior
The discounts array should be cleared as well.

Environment (please complete the following information):

@vendure/core version: v0.18.0
Nodejs version: v12.x.x
Database (mysql/postgres etc):postgresql

Additional context
Add any other context about the problem here.

gauravagrawal1710 added the type: bug 🐛 label

gauravagrawal1710 assigned michaelbromley

michaelbromley added this to the v0.18.2 milestone

michaelbromley closed this as completed in

e1cce8f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment