Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core) Fix swiss and congolese currency codes #302

Merged
merged 2 commits into from
Apr 13, 2020
Merged

fix(core) Fix swiss and congolese currency codes #302

merged 2 commits into from
Apr 13, 2020

Conversation

Tyratox
Copy link
Contributor

@Tyratox Tyratox commented Apr 13, 2020

I'm currently experimenting with vendure and so far like it quite a lot.
I currently think of migrating an existing e-commerce shop and am now checking whether I can implement all required features. While setting up a demo system I noticed that the swiss currency code is set to CHW instead of CHF. This is probably because ISO 4217 defines three currency codes for switzerland but CHF is the one usually used.

Screen Shot 2020-04-13 at 15 42 00

Also I noticed that the name used in the channel settings ("WIR euros") can't be found inside the repository so I'm not sure where to do this change/update.

@michaelbromley
Copy link
Member

Hi, thanks for the PR!

Also I noticed that the name used in the channel settings ("WIR euros") can't be found inside the repository so I'm not sure where to do this change/update.

The human-readable string for each code is handled by the CurrencyNamePipe which internally uses the browser's Intl API. So in theory this should always be correct.

The "CHE" currently listed as "Congolese franc" is then wrong - Congolese franc is "CDF". Would you be able to change that code in the same file too?

@Tyratox
Copy link
Contributor Author

Tyratox commented Apr 13, 2020

The human-readable string for each code is handled by the CurrencyNamePipe which internally uses the browser's Intl API. So in theory this should always be correct.

Ah perfect, no change is needed then.

The "CHE" currently listed as "Congolese franc" is then wrong - Congolese franc is "CDF". Would you be able to change that code in the same file too?

Of course!

@Tyratox Tyratox changed the title fix(core) Fix swiss currency code fix(core) Fix swiss and congolese currency codes Apr 13, 2020
@michaelbromley michaelbromley merged commit 2fbf37a into vendure-ecommerce:master Apr 13, 2020
@michaelbromley
Copy link
Member

Thank you for your help 👍

@Tyratox Tyratox deleted the swiss-currency-code branch April 13, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants