We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug When defining an EmailEventHandler, if the loadData method is used after the filter method, then the filters no longer work.
loadData
filter
To Reproduce
const handler = new EmailEventListener('test') .on(MockEvent) .filter(event => event.shouldSend === true) .loadData(context => Promise.resolve('loaded data')) .setRecipient(() => '[email protected]') .setFrom('"test from" <[email protected]>') .setSubject('test subject');
Expected behavior Filters should still work
Environment (please complete the following information):
Additional context The cause seems to be due to this:
vendure/packages/email-plugin/src/event-handler.ts
Lines 149 to 153 in 1cd27a1
When the EmailEventHandlerWithAsyncData is created, the this.filterFns array is not passed on.
EmailEventHandlerWithAsyncData
this.filterFns
The text was updated successfully, but these errors were encountered:
66bc98c
michaelbromley
No branches or pull requests
Describe the bug
When defining an EmailEventHandler, if the
loadData
method is used after thefilter
method, then the filters no longer work.To Reproduce
Expected behavior
Filters should still work
Environment (please complete the following information):
Additional context
The cause seems to be due to this:
vendure/packages/email-plugin/src/event-handler.ts
Lines 149 to 153 in 1cd27a1
When the
EmailEventHandlerWithAsyncData
is created, thethis.filterFns
array is not passed on.The text was updated successfully, but these errors were encountered: