configurable ui-language-switcher-dialog.component.ts
#2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for effervescent-donut-4977b2 canceled.
|
|
Also worth noting that during development session of this PR I figured out in some cases (at least during development) that if users didn't set I don't know if this is right to set configs inside |
michaelbromley
requested changes
Nov 28, 2023
packages/admin-ui/src/lib/core/src/components/app-shell/app-shell.component.ts
Outdated
Show resolved
Hide resolved
...lib/core/src/components/ui-language-switcher-dialog/ui-language-switcher-dialog.component.ts
Outdated
Show resolved
Hide resolved
…pOrDefault`'s check
…d for `availableLocales`
|
Thank you for your excellent work on this! |
|
Anytime 🙏 I'm glad it was helpful ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing the requirements described here #2413
Breaking changes
⭕There might be a chance that
getAppConfig().availableLocalesdon't filled with default value calleddefaultAvailableLocaleswhen user didn't set any specificavailableLocaleson theirAdminUiConfig.⭕Actually currently I couldn't verify 100% that this is going to break current users admin-ui as they probably have not set any
availableLocalesbut this might be the only breaking change.Screenshots
currently nothing applicable as a screenshot