Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(email-plugin): Expose template vars to template loader #2243

Conversation

StampixSMO
Copy link
Contributor

Closes #2242

Let me know if you'd like to pass more of the data object or if you somehow would hard-type the templateVars.

@michaelbromley
Copy link
Member

I was wondering whether it makes sense to pass the entire data object, but on reflection I think it is a safer approach to expose just the templateVars. In any case, the developer is able to put any arbitrary data in templateVars anyway, so that should be sufficient.

@michaelbromley michaelbromley merged commit 78ea016 into vendure-ecommerce:minor Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants