Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-existent routes should respond with 404 #187

Closed
michaelbromley opened this issue Oct 18, 2019 · 3 comments
Closed

Non-existent routes should respond with 404 #187

michaelbromley opened this issue Oct 18, 2019 · 3 comments
Assignees
Labels
type: bug 🐛 Something isn't working @vendure/core

Comments

@michaelbromley
Copy link
Member

Describe the bug
Currently, when requesting a route that is not defined, the server will hang and not return any response.

To Reproduce
Steps to reproduce the behavior:

  1. Start the Vendure server
  2. In the browser request http://localhost/bad-route
  3. Browser will hang, no response

Expected behavior
It should 404.

Environment (please complete the following information):

  • @vendure/core version: 0.4.0
  • Nodejs version: 12.4.0
  • Database (mysql/postgres etc): any
@Szbuli
Copy link

Szbuli commented Jan 27, 2020

This issue still happens to 401. For example if you create a custom rest endpoint, not sure about built in routes.

@Szbuli
Copy link

Szbuli commented Jan 28, 2020

The error happened when i added an authguard to the controller endpoint, but not added the authguard to nestjs (not set passportmodule as an import, and not set the strategy as a provider)

@Szbuli
Copy link

Szbuli commented Feb 18, 2020

If i throw a Forbidden error in a rest controller. It will not return 403 to the client, it will hang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working @vendure/core
Projects
None yet
Development

No branches or pull requests

2 participants