We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug In @vendure/admin-ui v0.3.1 there is an infinite loop on the CollectionList page which causes the app to hang.
To Reproduce Steps to reproduce the behavior:
Expected behavior Not hanging
Additional context Initial investigation shows this is an infinite change-detector loop caused by this line:
vendure/packages/admin-ui/src/app/shared/pipes/has-permission.pipe.ts
Line 37 in 5ee4564
That markForCheck() call was added to fix the issue where other uses of this pipe would not get change-detected in OnPush components.
markForCheck()
The text was updated successfully, but these errors were encountered:
230703f
michaelbromley
No branches or pull requests
Describe the bug
In @vendure/admin-ui v0.3.1 there is an infinite loop on the CollectionList page which causes the app to hang.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Not hanging
Additional context
Initial investigation shows this is an infinite change-detector loop caused by this line:
vendure/packages/admin-ui/src/app/shared/pipes/has-permission.pipe.ts
Line 37 in 5ee4564
That
markForCheck()
call was added to fix the issue where other uses of this pipe would not get change-detected in OnPush components.The text was updated successfully, but these errors were encountered: