Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3.1 Infinite loop on CollectionList page #170

Closed
michaelbromley opened this issue Sep 26, 2019 · 0 comments
Closed

0.3.1 Infinite loop on CollectionList page #170

michaelbromley opened this issue Sep 26, 2019 · 0 comments
Assignees
Labels

Comments

@michaelbromley
Copy link
Member

Describe the bug
In @vendure/admin-ui v0.3.1 there is an infinite loop on the CollectionList page which causes the app to hang.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Collections in the main nav
  2. Observe that the app is hung and the tab uses lots of CPU

Expected behavior
Not hanging

Additional context
Initial investigation shows this is an infinite change-detector loop caused by this line:

this.changeDetectorRef.markForCheck();

That markForCheck() call was added to fix the issue where other uses of this pipe would not get change-detected in OnPush components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant