Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product slug does not remove apostrophe #144

Closed
michaelbromley opened this issue Aug 26, 2019 · 0 comments
Closed

Product slug does not remove apostrophe #144

michaelbromley opened this issue Aug 26, 2019 · 0 comments
Assignees
Labels

Comments

@michaelbromley
Copy link
Member

Describe the bug
When creating a new product and typing the product name, the slug is automatically generated as a normalized version of the name. However, it does not remove apostrophes.

To Reproduce
Steps to reproduce the behavior:

  1. Go to "create new product" page
  2. Type "John's apples" into the name field
  3. The slug will now contain "john's-apples" with a validation error

Expected behavior
Apostrophe should be stripped out.

On further testing, these are also not stipped an should be:

  • .
  • =

Environment (please complete the following information):

  • @vendure/core version: 0.1.2-beta.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant