fix(admin-ui): Fix tax rate permissions so product variants do not need access to customer groups #1274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion on Slack:
I've leveraged the same convention found in other places, e.g.
GetProductSimple
andGetProductVariantListSimple
, and created a new query for tax rates that returns less fields - in this case,customerGroup
- and uses theSimple
suffix. I couldn't find other examples in the codebases so please let me know if I should take a different approach.