Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable automatic apply-collection-filters trigger (and possible for other tasks) #1124

Closed
skid opened this issue Sep 29, 2021 · 1 comment
Closed

Comments

@skid
Copy link
Contributor

skid commented Sep 29, 2021

Is your feature request related to a problem? Please describe.
The apply-collection-filters job is a bit slow when you have a lot of collections. It's also triggered indiscriminately - for example if the product variant's stockOnHand changes, which has nothing to do with collections, but can be a very frequent event. This can lead to a lot of expensive jobs being run unnecessarily.

Describe the solution you'd like
It would be good to have a way to disable specific jobs, on several levels:

  1. Globally - e.g. disable the apply-collection-filters hook completely and let me run it manually periodically
  2. Per operation - e.g. add a method to the RequestContext that would look something like: ctx.skipJobs('apply-collection-filters'). This one is not so useful, as we can already do that if we don't use Vendure's services to do DB operations.
@michaelbromley
Copy link
Member

Closing in favour of #1137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants