Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix collection update event generation #1114

Merged
merged 3 commits into from
Sep 28, 2021
Merged

fix(core): fix collection update event generation #1114

merged 3 commits into from
Sep 28, 2021

Conversation

Izayda
Copy link
Contributor

@Izayda Izayda commented Sep 24, 2021

Close #1015

@Izayda
Copy link
Contributor Author

Izayda commented Sep 24, 2021

Don't know why check failed. It's strange

michaelbromley
michaelbromley requested changes Sep 24, 2021
View reviewed changes
Copy link
Member

@michaelbromley michaelbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this was simpler than I had thought! Just check my comment and if you agree, make a minor change.

packages/core/src/service/services/collection.service.ts Show resolved Hide resolved
@Izayda
Copy link
Contributor Author

Izayda commented Sep 25, 2021

Probably close #728

michaelbromley
michaelbromley reviewed Sep 28, 2021
View reviewed changes
Copy link
Member

@michaelbromley michaelbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, otherwise looking good!

packages/core/src/service/services/collection.service.ts Outdated Show resolved Hide resolved
packages/core/src/service/services/collection.service.ts Outdated Show resolved Hide resolved
@michaelbromley michaelbromley merged commit 6e7e864 into vendure-ecommerce:master Sep 28, 2021
@michaelbromley
Copy link
Member

Thanks!

@Izayda Izayda deleted the #1015 branch September 28, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbromley michaelbromley michaelbromley requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ElasticSearch plugin: update Collection
2 participants
@Izayda @michaelbromley