Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product lookup by slug #108

Closed
michaelbromley opened this issue May 29, 2019 · 0 comments
Closed

Product lookup by slug #108

michaelbromley opened this issue May 29, 2019 · 0 comments

Comments

@michaelbromley
Copy link
Member

Is your feature request related to a problem? Please describe.
There is no way to lookup a product by its slug. The purpose of the slug is to be used in URLs, but without a slug-based lookup, the ID would also need to be stored in the URL too (as is the case with the demo storefront currently).

Describe the solution you'd like
First of all, slug values must be guaranteed to be unique (see #103). Then a lookup can be done either by extending the current product query so that the first argument is idOrSlug, or create a new query productBySlug.

Todo: research the pros & cons of each of the above alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant