fix(core): Fix deletion of Collections

Closes #297. The error was due to a foreign key violation on the CollectionAsset. Fixed by adding a delete cascade to the CollectionAsset BREAKING CHANGE: The CollectionAsset entity had a cascade delete defined, which will require a DB migration.
vendure-ecommerce · Apr 7, 2020 · 44916b7 · 44916b7
1 parent e304ae2
commit 44916b7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/core/e2e/collection.e2e-spec.ts b/packages/core/e2e/collection.e2e-spec.ts
@@ -486,6 +486,7 @@ describe('Collection resolver', () => {
                         translations: [
                             { languageCode: LanguageCode.en, name: 'Delete Me Parent', description: '' },
                         ],
+                        assetIds: ['T_1'],
                     },
                 },
             );
@@ -500,6 +501,7 @@ describe('Collection resolver', () => {
                             { languageCode: LanguageCode.en, name: 'Delete Me Child', description: '' },
                         ],
                         parentId: collectionToDeleteParent.id,
+                        assetIds: ['T_2'],
                     },
                 },
             );

diff --git a/packages/core/src/entity/collection/collection-asset.entity.ts b/packages/core/src/entity/collection/collection-asset.entity.ts
@@ -13,6 +13,6 @@ export class CollectionAsset extends OrderableAsset {
     @Column()
     collectionId: ID;
 
-    @ManyToOne(type => Collection, collection => collection.assets)
+    @ManyToOne((type) => Collection, (collection) => collection.assets, { onDelete: 'CASCADE' })
     collection: Collection;
 }