fix(admin-ui): Do not expose internal entity IDs

Closes #178
vendure-ecommerce · Oct 4, 2019 · 2ca9cc1 · 2ca9cc1
1 parent d50d488
commit 2ca9cc1
Show file tree

Hide file tree

Showing 13 changed files with 5 additions and 21 deletions.
diff --git a/packages/admin-ui/src/app/catalog/catalog.routes.ts b/packages/admin-ui/src/app/catalog/catalog.routes.ts
@@ -108,7 +108,7 @@ export function productVariantEditorBreadcrumb(data: any, params: any) {
                     link: ['../', 'products'],
                 },
                 {
-                    label: `#${params.id} (${entity.name})`,
+                    label: `${entity.name}`,
                     link: ['../', 'products', params.id, { tab: 'variants' }],
                 },
                 {

diff --git a/packages/admin-ui/src/app/common/detail-breadcrumb.ts b/packages/admin-ui/src/app/common/detail-breadcrumb.ts
@@ -20,7 +20,7 @@ export function detailBreadcrumb<T>(options: {
             if (options.id === 'create') {
                 label = 'common.create';
             } else {
-                label = `#${options.id} (${options.getName(entity)})`;
+                label = `${options.getName(entity)}`;
             }
             return [
                 {

diff --git a/packages/admin-ui/src/app/customer/components/customer-list/customer-list.component.html b/packages/admin-ui/src/app/customer/components/customer-list/customer-list.component.html
@@ -25,13 +25,11 @@
     (pageChange)="setPageNumber($event)"
     (itemsPerPageChange)="setItemsPerPage($event)"
 >
-    <vdr-dt-column>{{ 'common.ID' | translate }}</vdr-dt-column>
     <vdr-dt-column [expand]="true">{{ 'customer.name' | translate }}</vdr-dt-column>
     <vdr-dt-column [expand]="true">{{ 'customer.email-address' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'customer.customer-type' | translate }}</vdr-dt-column>
     <vdr-dt-column></vdr-dt-column>
     <ng-template let-customer="item">
-        <td class="left align-middle">{{ customer.id }}</td>
         <td class="left align-middle">
             {{ customer.title }} {{ customer.firstName }} {{ customer.lastName }}
         </td>

diff --git a/packages/admin-ui/src/app/marketing/components/promotion-list/promotion-list.component.html b/packages/admin-ui/src/app/marketing/components/promotion-list/promotion-list.component.html
@@ -18,15 +18,13 @@
     (pageChange)="setPageNumber($event)"
     (itemsPerPageChange)="setItemsPerPage($event)"
 >
-    <vdr-dt-column>{{ 'common.ID' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'common.name' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'common.created-at' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'common.updated-at' | translate }}</vdr-dt-column>
     <vdr-dt-column></vdr-dt-column>
     <vdr-dt-column></vdr-dt-column>
     <vdr-dt-column></vdr-dt-column>
     <ng-template let-promotion="item">
-        <td class="left align-middle">{{ promotion.id }}</td>
         <td class="left align-middle">{{ promotion.name }}</td>
         <td class="left align-middle">{{ promotion.createdAt | date: 'longDate' }}</td>
         <td class="left align-middle">{{ promotion.updatedAt | date: 'longDate' }}</td>

diff --git a/packages/admin-ui/src/app/order/components/order-history/order-history.component.html b/packages/admin-ui/src/app/order/components/order-history/order-history.component.html
@@ -75,7 +75,7 @@ <h4>{{ 'order.order-history' | translate }}</h4>
                     *ngIf="entry.data.to === 'Settled'; else regularPaymentTransition"
                 >
                     <div class="title">
-                        {{ 'order.history-payment-settled' | translate: { id: entry.data.paymentId } }}
+                        {{ 'order.history-payment-settled' | translate }}
                     </div>
                     {{ 'order.transaction-id' | translate }}: {{ getPayment(entry)?.transactionId }}
                     <vdr-history-entry-detail *ngIf="getPayment(entry) as payment">

diff --git a/packages/admin-ui/src/app/order/components/order-list/order-list.component.html b/packages/admin-ui/src/app/order/components/order-list/order-list.component.html
@@ -36,15 +36,13 @@
     (pageChange)="setPageNumber($event)"
     (itemsPerPageChange)="setItemsPerPage($event)"
 >
-    <vdr-dt-column>{{ 'common.ID' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'common.code' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'order.customer' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'order.state' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'order.total' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'common.updated-at' | translate }}</vdr-dt-column>
     <vdr-dt-column></vdr-dt-column>
     <ng-template let-order="item">
-        <td class="left align-middle">{{ order.id }}</td>
         <td class="left align-middle">{{ order.code }}</td>
         <td class="left align-middle">
             <vdr-customer-label [customer]="order.customer"></vdr-customer-label>

diff --git a/...es/admin-ui/src/app/order/components/order-payment-card/order-payment-card.component.html b/...es/admin-ui/src/app/order/components/order-payment-card/order-payment-card.component.html
@@ -1,6 +1,6 @@
 <div class="card">
     <div class="card-header payment-header">
-        <div>{{ 'order.payment' | translate }} #{{ payment.id }}</div>
+        <div>{{ 'order.payment' | translate }} #{{ payment.transactionId }}</div>
         <div class="payment-state">
             <vdr-payment-state-label [state]="payment.state"></vdr-payment-state-label>
         </div>

diff --git a/...admin-ui/src/app/settings/components/administrator-list/administrator-list.component.html b/...admin-ui/src/app/settings/components/administrator-list/administrator-list.component.html
@@ -16,13 +16,11 @@
     (pageChange)="setPageNumber($event)"
     (itemsPerPageChange)="setItemsPerPage($event)"
 >
-    <vdr-dt-column>{{ 'common.ID' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'settings.first-name' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'settings.last-name' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'settings.email-address' | translate }}</vdr-dt-column>
     <vdr-dt-column></vdr-dt-column>
     <ng-template let-administrator="item">
-        <td class="left align-middle">{{ administrator.id }}</td>
         <td class="left align-middle">{{ administrator.firstName }}</td>
         <td class="left align-middle">{{ administrator.lastName }}</td>
         <td class="left align-middle">{{ administrator.emailAddress }}</td>

diff --git a/packages/admin-ui/src/app/settings/components/channel-list/channel-list.component.html b/packages/admin-ui/src/app/settings/components/channel-list/channel-list.component.html
@@ -9,11 +9,9 @@
 </vdr-action-bar>
 
 <vdr-data-table [items]="channels$ | async">
-    <vdr-dt-column>{{ 'common.ID' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'common.code' | translate }}</vdr-dt-column>
     <vdr-dt-column></vdr-dt-column>
     <ng-template let-channel="item">
-        <td class="left align-middle">{{ channel.id }}</td>
         <td class="left align-middle">{{ channel.code }}</td>
         <td class="right align-middle">
             <vdr-table-row-action

diff --git a/packages/admin-ui/src/app/settings/components/role-list/role-list.component.html b/packages/admin-ui/src/app/settings/components/role-list/role-list.component.html
@@ -16,13 +16,11 @@
     (pageChange)="setPageNumber($event)"
     (itemsPerPageChange)="setItemsPerPage($event)"
 >
-    <vdr-dt-column>{{ 'common.ID' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'common.code' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'common.description' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'settings.permissions' | translate }}</vdr-dt-column>
     <vdr-dt-column></vdr-dt-column>
     <ng-template let-role="item">
-        <td class="left align-middle">{{ role.id }}</td>
         <td class="left align-middle">{{ role.code }}</td>
         <td class="left align-middle">{{ role.description }}</td>
         <td class="left align-middle">

diff --git a/...s/admin-ui/src/app/settings/components/tax-category-list/tax-category-list.component.html b/...s/admin-ui/src/app/settings/components/tax-category-list/tax-category-list.component.html
@@ -9,11 +9,9 @@
 </vdr-action-bar>
 
 <vdr-data-table [items]="taxCategories$ | async">
-    <vdr-dt-column>{{ 'common.ID' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'common.name' | translate }}</vdr-dt-column>
     <vdr-dt-column></vdr-dt-column>
     <ng-template let-taxCategory="item">
-        <td class="left align-middle">{{ taxCategory.id }}</td>
         <td class="left align-middle">{{ taxCategory.name }}</td>
         <td class="right align-middle">
             <vdr-table-row-action

diff --git a/packages/admin-ui/src/app/settings/components/tax-rate-list/tax-rate-list.component.html b/packages/admin-ui/src/app/settings/components/tax-rate-list/tax-rate-list.component.html
@@ -16,14 +16,12 @@
     (pageChange)="setPageNumber($event)"
     (itemsPerPageChange)="setItemsPerPage($event)"
 >
-    <vdr-dt-column>{{ 'common.ID' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'common.name' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'settings.tax-category' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'settings.zone' | translate }}</vdr-dt-column>
     <vdr-dt-column>{{ 'settings.tax-rate' | translate }}</vdr-dt-column>
     <vdr-dt-column></vdr-dt-column>
     <ng-template let-taxRate="item">
-        <td class="left align-middle">{{ taxRate.id }}</td>
         <td class="left align-middle">{{ taxRate.name }}</td>
         <td class="left align-middle">{{ taxRate.category.name }}</td>
         <td class="left align-middle">{{ taxRate.zone.name }}</td>

diff --git a/packages/admin-ui/src/i18n-messages/en.json b/packages/admin-ui/src/i18n-messages/en.json
@@ -433,7 +433,7 @@
     "history-order-cancelled": "Order cancelled",
     "history-order-fulfilled": "Order fulfilled",
     "history-order-transition": "Order transitioned from {from} to {to}",
-    "history-payment-settled": "Payment #{id} settled",
+    "history-payment-settled": "Payment settled",
     "history-payment-transition": "Payment #{id} transitioned from {from} to {to}",
     "history-refund-transition": "Refund #{id} transitioned from {from} to {to}",
     "item-count": "{count} {count, plural, one {item} other {items}}",