fix(core): Correctly calculate item price discount actions

Was not taking into account existing promotions previously.
vendure-ecommerce · Aug 20, 2020 · 06bb780 · 06bb780
1 parent 77284c3
commit 06bb780
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/core/src/config/promotion/actions/facet-values-discount-action.ts b/packages/core/src/config/promotion/actions/facet-values-discount-action.ts
@@ -26,7 +26,7 @@ export const discountOnItemWithFacets = new PromotionItemAction({
     },
     async execute(orderItem, orderLine, args) {
         if (await facetValueChecker.hasFacetValues(orderLine, args.facets)) {
-            return -orderLine.unitPrice * (args.discount / 100);
+            return -orderItem.unitPriceWithPromotions * (args.discount / 100);
         }
         return 0;
     },

diff --git a/packages/core/src/config/promotion/actions/product-discount-action.ts b/packages/core/src/config/promotion/actions/product-discount-action.ts
@@ -26,7 +26,7 @@ export const productsPercentageDiscount = new PromotionItemAction({
 
     execute(orderItem, orderLine, args) {
         if (lineContainsIds(args.productVariantIds, orderLine)) {
-            return -orderLine.unitPrice * (args.discount / 100);
+            return -orderItem.unitPriceWithPromotions * (args.discount / 100);
         }
         return 0;
     },