-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(core): Correctly prefix asset urls for resolved properties
Closes #146
- Loading branch information
1 parent
f687cc8
commit 0517b6c
Showing
7 changed files
with
106 additions
and
296 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
packages/core/src/api/middleware/asset-interceptor-plugin.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| import { Asset } from '@vendure/common/lib/generated-types'; | ||
| import { ApolloServerPlugin, GraphQLRequestListener, GraphQLServiceContext } from 'apollo-server-plugin-base'; | ||
| import { DocumentNode } from 'graphql'; | ||
|
|
||
| import { AssetStorageStrategy } from '../../config/asset-storage-strategy/asset-storage-strategy'; | ||
| import { ConfigService } from '../../config/config.service'; | ||
| import { GraphqlValueTransformer } from '../common/graphql-value-transformer'; | ||
|
|
||
| /** | ||
| * Transforms outputs so that any Asset instances are run through the {@link AssetStorageStrategy.toAbsoluteUrl} | ||
| * method before being returned in the response. | ||
| */ | ||
| export class AssetInterceptorPlugin implements ApolloServerPlugin { | ||
| private graphqlValueTransformer: GraphqlValueTransformer; | ||
| private readonly toAbsoluteUrl: AssetStorageStrategy['toAbsoluteUrl'] | undefined; | ||
|
|
||
| constructor(private configService: ConfigService) { | ||
| const { assetOptions } = this.configService; | ||
| if (assetOptions.assetStorageStrategy.toAbsoluteUrl) { | ||
| this.toAbsoluteUrl = assetOptions.assetStorageStrategy.toAbsoluteUrl.bind( | ||
| assetOptions.assetStorageStrategy, | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| serverWillStart(service: GraphQLServiceContext): Promise<void> | void { | ||
| this.graphqlValueTransformer = new GraphqlValueTransformer(service.schema); | ||
| } | ||
|
|
||
| requestDidStart(): GraphQLRequestListener { | ||
| return { | ||
| willSendResponse: requestContext => { | ||
| const { document } = requestContext; | ||
| if (document) { | ||
| const data = requestContext.response.data; | ||
| const req = requestContext.context.req; | ||
| if (data) { | ||
| this.prefixAssetUrls(req, document, data); | ||
| } | ||
| } | ||
| }, | ||
| }; | ||
| } | ||
|
|
||
| private prefixAssetUrls(request: any, document: DocumentNode, data: Record<string, any>) { | ||
| const typeTree = this.graphqlValueTransformer.getOutputTypeTree(document); | ||
| const toAbsoluteUrl = this.toAbsoluteUrl; | ||
| if (!toAbsoluteUrl) { | ||
| return; | ||
| } | ||
| this.graphqlValueTransformer.transformValues(typeTree, data, (value, type) => { | ||
| const isAssetType = type && type.name === 'Asset'; | ||
| if (isAssetType) { | ||
| if (value && !Array.isArray(value)) { | ||
| if (value.preview) { | ||
| value.preview = toAbsoluteUrl(request, value.preview); | ||
| } | ||
| if (value.source) { | ||
| value.source = toAbsoluteUrl(request, value.source); | ||
| } | ||
| } | ||
| } | ||
| const isSearchResultType = type && type.name === 'SearchResult'; | ||
| if (isSearchResultType) { | ||
| if (value && !Array.isArray(value)) { | ||
| if (value.productPreview) { | ||
| value.productPreview = toAbsoluteUrl(request, value.productPreview); | ||
| } | ||
| if (value.productVariantPreview) { | ||
| value.productVariantPreview = toAbsoluteUrl(request, value.productVariantPreview); | ||
| } | ||
| } | ||
| } | ||
| return value; | ||
| }); | ||
| } | ||
| } |
Oops, something went wrong.