Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Edge and "allowWebWorkers" if debug is enabled #476

Closed
Avijobo opened this issue Aug 21, 2017 · 12 comments
Closed

Windows Edge and "allowWebWorkers" if debug is enabled #476

Avijobo opened this issue Aug 21, 2017 · 12 comments

Comments

@Avijobo
Copy link

Avijobo commented Aug 21, 2017

For your information: when using Edge browser, sometimes file upload does not start or gets halted after a few chunks when "allowWebworkers" is set (= default). In these cases the upload state remains "active" however nothing happens anymore, no errors occur, the file just does not get uploaded any further.

All works well on Edge if "allowWebworkers" is set to false.

@dr-dimitru
Copy link
Member

Hello @Avijobo ,

Thank you for this report.

Could you please confirm this is the case for our demo app? (I don't have access to Edge now).

@Avijobo
Copy link
Author

Avijobo commented Aug 21, 2017

Yes I can get a similar behavior with the demo app, but it doesn't always occur, and you need to upload files simultaneously. I uploaded 4 files (+- 20MB each) simultaneously, and after about 70% the uploads halted. When clicking the "resume" button (which I don't have in my app... is there a real need to?) I could get all 4 files continuing to upload, but at the end only 1 file was intact, the other 3 were "damaged" on the server and contained errors.

@dr-dimitru
Copy link
Member

which I don't have in my app... is there a real need to?

It might be a good option if app is made to upload large files, which may help in case of network failures.

Thank you for report it will require us to investigate it.
Hope if anyone else having this issue will report too.

@Avijobo please name exact version of Windows and Edge you're using.

@Avijobo
Copy link
Author

Avijobo commented Aug 21, 2017

Windows 10 Pro Version 1607 OS Build 14393.1593
Microsoft Edge 38.14393.1066.0

@dr-dimitru
Copy link
Member

dr-dimitru commented Aug 21, 2017

@Avijobo what you have described here, reminds me about #458 , where Safari on Mac and iOS was hanging with multiple upload streams and large chunk size. The solution is to use http transport, with {stream: 1, chunkSize: 102400} options passed to .insert() method, see this comment for more info.

Could you please confirm this happens on ddp and http transports or only one of them?

@dr-dimitru
Copy link
Member

I know @mozibrand and @laosb have experience with IE and helped to test and make this package compatible with IE.

Guys, I'll be glad if you can share your thoughts on this issue.

@laosb
Copy link

laosb commented Aug 22, 2017

I don't have access to Windows machines at this moment, but if you have any further questions I can try to gain it. 😉

@Avijobo
Copy link
Author

Avijobo commented Aug 24, 2017

Update: I also had similar problems with the "demo-simplest-upload" app: both Edge and IE11 did not start uploading a file, unless their "developer tools" were active in the browser.... very weird.

Fix: Set 'debug' option to false in the FilesCollection constructor config.

If 'debug: true' is set in these browsers, uploads do not get started, not in developer mode or production mode, and regardless of the upload settings (http/ddp, allowWebWorkers etc...).
If 'debug: false' is set (or 'debug; field is omitted), everything works as expected, with all upload settings.

@dr-dimitru
Copy link
Member

If 'debug: true' is set in these browsers, uploads do not get started, not in developer mode or production mode, and regardless of the upload settings (http/ddp, allowWebWorkers etc...).
If 'debug: false' is set (or 'debug; field is omitted), everything works as expected, with all upload settings.

This is very useful, we will try to find a root of the issue. Meanwhile you're good with disabled debug, right?

@Avijobo
Copy link
Author

Avijobo commented Aug 24, 2017

Yes, perfect! I am happy Edge and IE11 work perfect now, also in production... once again thanks for your commitment!

@dr-dimitru
Copy link
Member

Thank you. Let's keep it open, unless we find the root of the issue.

@dr-dimitru dr-dimitru changed the title Windows Edge and "allowWebWorkers" Windows Edge and "allowWebWorkers" if debug is enabled Sep 10, 2017
@dr-dimitru dr-dimitru changed the title Windows Edge and "allowWebWorkers" if debug is enabled Windows Edge and "allowWebWorkers" if debug is enabled Sep 10, 2017
@dr-dimitru
Copy link
Member

@Avijobo can not reproduce it on our end.
Marked as [In a case of the fire - Read This] if someone else will run into the same issue, and renamed to Windows Edge and "allowWebWorkers" if debug is enabled.

Feel free to reopen it in case if the issue still persists on your end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants