-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Horizontal Bar chart collapsed in 5.16.1 #9453
Comments
I'll let @kanitw chime in with more details about the previous PR, but I'm curious about the use case for having |
@joelostblom Good question (And thanks for the fast response!). I reached out to the original poster of the issue for their reasoning since Streamlit just passes down the altair chart to vega-lite with minor modifications. The example seems like a toy example, so perhaps their use case will be more clear. |
Without a y we should probably treat the y offset as y and show a warning. This could be done in preprocessing. But maybe the original poster had a case with both. |
Following up (Sorry for the delay!) The user does not have a specific use case for yOffset with no y. A warning would be helpful, but since Vega is working as expected, I'll close the issue. |
Bug Description
We noticed an issue with our horizontal bar charts after upgrading Vega-Lite to the latest version. Doing some Git bisecting, we can tie the change to 5.16.1 which makes me think something is going on from #9135 @kanitw perhaps you have some idea on what's going on?
For what it's worth, this chart is generated in Altair in Streamlit with a Y Offset (See streamlit/streamlit#9604).
The generated vega-lite spec is below.
Before (5.16.0)
After (5.16.1)
The text was updated successfully, but these errors were encountered: