Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: describe how to set a custom scheme by setting the range, reverts #9262 #9266

Merged
merged 4 commits into from
Mar 19, 2024
Merged

fix: describe how to set a custom scheme by setting the range, reverts #9262 #9266

merged 4 commits into from
Mar 19, 2024

Conversation

domoritz
Copy link
Member

reverts #9262
fixes #9022

These two seem to be equivalent so let's officially support only the simpler one.

Screenshot 2024-02-18 at 10 27 34

@domoritz domoritz requested a review from a team as a code owner February 18, 2024 01:28
@domoritz domoritz mentioned this pull request Feb 18, 2024
Merged
hydrosquall
hydrosquall approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@hydrosquall hydrosquall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me. Even though the code supports the string[] syntax at runtime, if there's no benefit to supporting both forms, it makes sense to steer people towards the more explicit form (scale.range).

@domoritz domoritz merged commit e6af641 into main Mar 19, 2024
9 checks passed
@domoritz domoritz deleted the dom/array-fix branch March 19, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hydrosquall hydrosquall hydrosquall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support array of values for scheme
2 participants
@domoritz @hydrosquall