fix: support arrays in color schemes #9262
Conversation
There was a problem hiding this comment.
Thanks for making the change, I noticed this issue before but didn't know if perhaps this shorthand for setting scale.range wasn't meant to be supported. I didn't run this locally but it looks like this should work.
For future PRs - what does the workflow look like for testing changes like this? One thought is that launching a preview build of the Vega editor using this branch's version of the library could help with QA so we can validate that specs like this are schema checked happily (e.g. no yellow squiggle under the array in the JSON.).
| @@ -611,7 +611,7 @@ export interface Scale<ES extends ExprRef | SignalRef = ExprRef | SignalRef> { | |||
| * | |||
| * For the full list of supported schemes, please refer to the [Vega Scheme](https://vega.github.io/vega/docs/schemes/#reference) reference. | |||
There was a problem hiding this comment.
Should we advertise this capability in the docs and/or a docstring?
https://vega.github.io/vega-lite/docs/scale.html#2-setting-the-range-property-to-an-array-of-valid-css-color-strings seems close but it targets scale.range rather advertising allowing scheme to be immediately set as an array. I'm assuming this arrays is a faster shorthand for the same behavior.
There was a problem hiding this comment.
Good point. I think we should revert this change since there ideally aren't multiple ways to do the same thing.
| @@ -21928,6 +21928,12 @@ | |||
| { | |||
| "$ref": "#/definitions/ColorScheme" | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Confirmed that this matches what we see in the underlying Vega types for RangeScheme 👍
Right now, local checkout is needed. A preview of the editor would be awesome (similarly a preview of the website). |
I've made an issue for looking into this, I'll see if we can do this without any 3rd party providers: #9276 |
…#9262 (#9266) reverts #9262 fixes #9022 These two seem to be equivalent so let's officially support only the simpler one. <img width="353" alt="Screenshot 2024-02-18 at 10 27 34" src="https://github.com/vega/vega-lite/assets/589034/36ec606c-2fbd-4777-9442-c13536ecc8bd"> --------- Co-authored-by: GitHub Actions Bot <[email protected]>
fixes #9022