Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exported types for 4.16.2 are missing some files #6900

Closed
alexwizp opened this issue Sep 25, 2020 · 9 comments · Fixed by #6901
Closed

exported types for 4.16.2 are missing some files #6900

alexwizp opened this issue Sep 25, 2020 · 9 comments · Fixed by #6901
Assignees
Labels
Bug 🐛 P1 Critical -- to fix ASAP

Comments

@alexwizp
Copy link

alexwizp commented Sep 25, 2020

After updating vega-lite lib to version 4.16.2 I see the following issue during types checking

image

It looks like the file being imported is only types, which probably means that the ./impute import should be removed from the file or the module should be left on the file system.

image

@alexwizp alexwizp changed the title Upda [Vega-lite] [4.16.2] types error Sep 25, 2020
@domoritz
Copy link
Member

I am aware of this issue. The problem is a bug in https://github.com/ezolenko/rollup-plugin-typescript2. For now, please hold off on updating while we work out this issue.

@domoritz domoritz changed the title [Vega-lite] [4.16.2] types error exported types for 4.16.2 are missing some files Sep 25, 2020
@domoritz domoritz self-assigned this Sep 25, 2020
@domoritz domoritz added the P1 Critical -- to fix ASAP label Sep 25, 2020
@alexwizp
Copy link
Author

alexwizp commented Sep 28, 2020

@domoritz
We still have some issues on vega-lite side on v4.16.7

image

@domoritz
Copy link
Member

@alexwizp Thanks for the follow-up. Can you confirm that you only have 4.16.7 and the latest version of Typescript?

@alexwizp
Copy link
Author

Yep, vega-lite: 4.16.7 and Typescript version: 4.0.2

@domoritz
Copy link
Member

Did you enable "resolveJsonModule": true? I am not seeing any problems in the Vega editor (https://github.com/vega/editor) anymore. Do you have a simple repro?

@alexwizp
Copy link
Author

@domoritz sorrry, my question was more about

node_modules/vega-lite/build/src/vega.schema.d.ts:34:19 - error TS2344: Type 'null' does not satisfy the constraint 'SignalRef | ExprRef'.

      34     value?: Value<null>;

@domoritz
Copy link
Member

Do you have strict null checks enabled?

@alexwizp
Copy link
Author

"strict": true property is on
our config: https://github.com/elastic/kibana/blob/master/tsconfig.base.json

@domoritz
Copy link
Member

I see. That could be it. We don't have it enabled (https://github.com/vega/vega-lite/blob/master/tsconfig.json#L13) but we could (and should) fix the problem you are seeing.

Let's move that discussion to #6912.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 P1 Critical -- to fix ASAP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants