-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exported types for 4.16.2 are missing some files #6900
Comments
I am aware of this issue. The problem is a bug in https://github.com/ezolenko/rollup-plugin-typescript2. For now, please hold off on updating while we work out this issue. |
@domoritz |
@alexwizp Thanks for the follow-up. Can you confirm that you only have 4.16.7 and the latest version of Typescript? |
Yep, vega-lite: 4.16.7 and Typescript version: 4.0.2 |
Did you enable |
@domoritz sorrry, my question was more about
|
Do you have strict null checks enabled? |
|
I see. That could be it. We don't have it enabled (https://github.com/vega/vega-lite/blob/master/tsconfig.json#L13) but we could (and should) fix the problem you are seeing. Let's move that discussion to #6912. |
After updating
vega-lite
lib to version4.16.2
I see the following issue during types checkingIt looks like the file being imported is only types, which probably means that the ./impute import should be removed from the file or the module should be left on the file system.
The text was updated successfully, but these errors were encountered: