feat: Add a logger to embed init options #732
Conversation
challet
changed the title
src/embed.ts
Outdated
| @@ -10,6 +10,8 @@ import { | |||
| isString, | |||
| Loader, | |||
| LoaderOptions, | |||
| logger as VgLogger, | |||
There was a problem hiding this comment.
| logger as VgLogger, | |
| logger as vegaLogger, |
Co-authored-by: Dominik Moritz <[email protected]>
Isn't it already done since the part that adds the logger works with both Vega and Vega-Lite specs ? The mode having been guessed a few lines before. |
|
I don't think it is. We call |
|
@challet can you finish up the pull request? |
| @@ -304,7 +304,7 @@ async function _embed( | |||
|
|
|||
| const mode = guessMode(spec, opts.mode); | |||
|
|
|||
| let vgSpec: VgSpec = PREPROCESSOR[mode](spec, config); | |||
| let vgSpec: VgSpec = PREPROCESSOR[mode](spec, { ...config, logger }); | |||
There was a problem hiding this comment.
Can be added directly to the passed config, since the whole arg will be discarded when the mode is not 'vega-lite'
|
@domoritz sorry it went out of my scope. I haven't added a test for the last change though and I will have a closer look at it. |
|
Thank you. Can you make sure the test pass? |
|
Ping @challet |
|
Sorry, I will have a look in the next days. |
Add an option to the
embedfunction.It allows to pass a custom logger to the view.